Ticket #2924 (closed theme: not-approved)

Opened 15 months ago

Last modified 15 months ago

THEME: Unwakeable - 1.5.5

Reported by: tlongren Owned by: chipbennett
Priority: Keywords: theme-unwakeable,
Cc: tlongren@…

Change History

comment:1 Changed 15 months ago by tlongren

Bumped to version 1.5.5 and incorporated changes from here:
http://themes.trac.wordpress.org/ticket/2916#comment:3

comment:2 Changed 15 months ago by tlongren

Can I pay someone to review this? ;)

comment:3 Changed 15 months ago by chipbennett

  • Owner set to chipbennett
  • Status changed from new to assigned

comment:4 Changed 15 months ago by chipbennett

  • Status changed from assigned to closed
  • Resolution set to not-approved

Previous Ticket Issues

  • (NOT OK) Translation textdomain: textdomain missing in some translation strings
    • Note: textdomain changed to unwakeable_domain. It should be theme-slug exactly, i.e. unwakeable.

Theme Check Required

  • REQUIRED: Could not find comment_form\. See:  comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: sidebar.php Please use get_search_form() instead of including searchform.php directly.
    Line 7: <?php include (TEMPLATEPATH . '/searchform.php'); ?>
    

Theme Check Recommended

  • RECOMMENDED: Text domain problems in app/includes/wp-compat.php. You have not included a text domain!
    Line 290: $text = __('Home');
    
  • RECOMMENDED: get_bloginfo('url') was found in the file app/classes/k2.php. Use home_url() instead.
    Line 321: return get_bloginfo('url') . '/';
    
  • RECOMMENDED: get_bloginfo('template_url') was found in the file app/includes/info.php. Use get_template_directory_uri() instead.
    Line 59: echo get_bloginfo('template_url') .'/'. $file;
    
  • RECOMMENDED: get_bloginfo('template_directory') was found in the file app/classes/k2.php. Use get_template_directory_uri() instead.
  • RECOMMENDED: bloginfo('url') was found in the file searchform.php. Use echo home_url() instead.
    Line 1: <form method='get' id='searchform' action='<?php bloginfo('url'); ?>'>
    
  • RECOMMENDED: bloginfo('url') was found in the file app/classes/k2.php. Use echo home_url() instead.
    Line 484: K2.AjaxURL = '<?php bloginfo('url'); ?>/';
    

Required

  • Use wp_nav_menu() in header nav menu, rather than wp_list_pages() (which can be used, but only as a fallback)
  • Remove backwards-compatibility code for anything prior to WP 3.0.

Review Summary

This is a cursory review only. This Theme failed a sufficient number of criteria to warrant discontinuing further review. Prior to re-submitting, please ensure Theme meets all requirements in the  Theme Review Guidelines and the  Theme Unit Tests. Once these issues have been resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.

Note:

  • Re-submitted Themes are given review priority over new Themes.
  • Test your Theme using the  Theme Check tool, and ensure that no errors are found, prior to re-submission.

Responding To This Review

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

1) Leave a comment on this ticket
2) Email the theme-reviewers email list
3) Use the #wordpress-themes channel on irc.freenode.net

comment:5 Changed 15 months ago by tlongren

Thanks! Will fix and resubmit soon!

comment:6 Changed 15 months ago by tlongren

OK, all these issues have been fixed with the exception of comment_form. By the way, thanks for the review Chip, very much appreciated!

Anyway, comment_form is absolutely 100% required to be in the theme for approval?

comment:7 Changed 15 months ago by chipbennett

Use of the comment_form() function for outputting the comment reply form is required.

What are your concerns with using it, that cannot be addressed via the many hooks built-in to the function?

comment:8 Changed 15 months ago by tlongren

No concerns. Just wanted to make sure before I rewrite comments.php. Thanks again Chip!

comment:9 Changed 15 months ago by tlongren

OK, the form that was hand-coded into comments.php is gone and comment_form is now in use. Will go over all these issues again before submitting a new version.

Thanks again chip!

Note: See TracTickets for help on using tickets.