Ticket #4056 (closed theme: not-approved)

Opened 12 months ago

Last modified 12 months ago

THEME: Basics - 0.2.4.1

Reported by: br1o Owned by: greenshady
Priority: major Keywords: theme-basics
Cc: infographiste@…

Change History

comment:1 Changed 12 months ago by greenshady

  • Owner set to greenshady
  • Status changed from new to accepted

comment:2 Changed 12 months ago by greenshady

  • Status changed from accepted to closed
  • Resolution set to not-approved

WP Debug

All themes should be tested with WP_DEBUG turned on and all debug issues cleared before submission.

Notice: Undefined variable: new_defaults in C:\xampplite\htdocs\wp-content\themes\test\comments.php on line 66

Notice: Undefined variable: aria_req in C:\xampplite\htdocs\wp-content\themes\test\functions.php on line 549

Notice: Undefined variable: aria_req in C:\xampplite\htdocs\wp-content\themes\test\functions.php on line 551

Notice: Undefined variable: post_id in C:\xampplite\htdocs\wp-content\themes\test\functions.php on line 562

Notice: Undefined variable: post_id in C:\xampplite\htdocs\wp-content\themes\test\functions.php on line 563

Remove files

You need to remove these files from the theme folder:

utils/.htaccess
utils/robots.txt
utils/languages.zip
js/mylibs/.gitignore
js/libs/jquery-1.5.1.js
js/libs/jquery-1.5.1-min.js

Contact Form

Your contact form template won't work within a sub-folder. It must be in the theme root folder to properly work.

Also, you to validate/sanitize all data being sent through the form:
 http://codex.wordpress.org/Data_Validation

And, you should use the wp_mail() function, not the mail() function for sending emails.

Footer code

There are several problems with this code:

<span id="administrator" class="vcard">
	<a class="fn n email" title="<?php the_author_meta( 'display_name', 1 ); ?> <?php bloginfo( 'admin_email' ); ?>" href="mailto:<?php bloginfo( 'admin_email' ); ?>">
	<?php _e( 'Contact the administrator ', 'basics' ); ?>
	</a>
</span>

You don't know that the user with the ID of 1 is the administrator of the site. You should also never publicly show a user's email address on the front end of the site.

Header

The following code needs to be removed. You don't know that the user with the ID of 1 is the administrator of the site or the author of the content.

<meta name="author" content="<?php the_author_meta( 'display_name', 1 ); ?>">

You need to use get_template_directory_uri() instead of get_stylesheet_directory_uri() in the following code. Also, any icons/favicons like you've added must be optional and can only be added via a theme option.

<link rel="shortcut icon" href="<?php echo get_stylesheet_directory_uri(); ?>/img/icons/favicon.ico">
<link rel="apple-touch-icon" href="<?php echo get_stylesheet_directory_uri(); ?>/img/icons/apple-touch-icon.png">
<link rel="stylesheet" href="<?php echo get_stylesheet_uri(); ?>?v=0.2.4">

You also need to use get_template_directory_uri() in this line:

<a class="url bookmark" href="<?php echo home_url( '/' ); ?>" rel="home nofollow"><img alt="<?php bloginfo( 'name' ); ?>" src="<?php echo get_stylesheet_directory_uri(); ?>/img/logo.png"></a>

This line must be removed because it's creating duplicate feed links:

<link rel="alternate" type="application/rss+xml" title="<?php printf( __( 'Subscribe to %1$s via RSS', 'basics' ), get_bloginfo( 'name' ) ); ?>" href="<?php echo home_url( '/feed/' ); ?>">

Home/blog template

The home.php template is for showing the latest blog posts for the site. Please don't change this and create custom queries. If you want to create a template with custom post queries, you should create a custom page template.

Nav menus

The "first", "third", and "fourth" nav menu locations are not used anywhere in the theme. They're just registered but not shown on the site anywhere.

Don't remove WP filters

You need to have an extremely good reason for removing WordPress? filters such as:

remove_filter('term_description','wpautop');

That's the auto-paragraph functionality you're removing and will break many user's content.

Scripts and styles

Additional scripts should be appropriately loaded using wp_enqueue_script():
 http://codex.wordpress.org/Function_Reference/wp_enqueue_script

Review

If you have any questions about the review, please check the Theme Review guidelines or ask in the form below. I'll be happy to help out.
 http://codex.wordpress.org/Theme_Review

Note that this is not a complete review. Other theme reviewers may find other issues. Please follow all the notes in the Theme Review guidelines.

Note: See TracTickets for help on using tickets.