Ticket #443 (closed theme: not-approved)

Opened 22 months ago

Last modified 21 months ago

THEME: SimpleDark - 1.1.6

Reported by: themetracbot Owned by: chipbennett
Priority: Keywords: theme-simpledark,
Cc:

Description

SimpleDark? - 1.1.6

You can <strong><a href="themes.php?page=SimpleDarkAdmin?">configure SimpleDark? here</a></strong> or visit <a href=" http://lync.in/simpledark/">Lync.in</a> for further support. SimpleDark? was designed and developed by <a href=" http://lync.in/">Justice</a> and is licensed under the <a href=" http://www.opensource.org/licenses/gpl-license.php">GPL</a>.

Theme URL -
Author URL -  http://lync.in/

SVN -  http://themes.svn.wordpress.org/simpledark/1.1.6

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-simpledark

Change History

comment:1 Changed 22 months ago by chipbennett

  • Owner set to chipbennett
  • Status changed from new to assigned

comment:2 Changed 22 months ago by chipbennett

Some initial notes (review to be continued).

Deprecated Calls:

utilities/admin.php - Line 21: add_theme_page(): Usage of user levels by plugins and themes is deprecated. Use roles and capabilities instead. Deprecated in version 2.0.

Front-End Display:

Page menu obscures site description. Unintuitive display for multi-line page menu.

(Please leave un-resolved until review is completed.)

comment:3 Changed 21 months ago by chipbennett

  • Status changed from assigned to closed
  • Resolution set to not-accepted

More:

Required Theme functionality. Does not support:

  • add_custom_image_header()
  • add_custom_background()
  • add_editor_style()
  • wp_nav_menu()
  • add_theme_support(automatic-feed-links)
  • add_theme_support(post-thumbnails)
  • comment_form()
  • wp_link_pages()
  • $content_width

Validation:

  • 3 HTML validation errors, all involving the custom comment form.
  • Numerous errors with CSS 3 validation, not all of which are allowable exceptions
  • AJAX not working properly: post pagination links simply reload page 1, rather than loading linked page
  • AJAX not working properly: search results reload in whatever page is rendered, causing navigation cues to indicate incorrectly when search results are displayed.

Footer link:

  • Two links to same URI. Only one author/Theme attribution link is allowed in the footer.

Theme Unit Tests:

  • Layout Test: Ajax pagination did not work properly on my install. Clicking post-page links for subsequent pages merely reloaded page 1.
  • Layout Test: Definition List (DL) not styled.
  • Layout Test: Ordered List (OL) indentation insufficient.
  • Layout Test: the following HTML tags are not styled: ADDRESS, CITE, VAR
  • Readability Test: I think the paragraphs could use more whitespace, especially given the reversed-contrast nature of the Theme. Personal preference, but I would suggest a little more line-height.
  • Images Test: Centered Image with caption: caption centered, but image not centered.
  • Images Test: the H2 for "Gallery Test" either needs to be block-level, or clear:both so that it doesn't render next to the floated thumbnail images above it.
  • Images Test: attachment page doesn't display image caption
  • Images Test: attachment page resizes all images to medium. Suggest displaying full-size (with or without max-width defined), or at least "large" size images on attachment page
  • Comments Test: Author Comment not styled
  • Parent/Child? Pages: the Theme provides no navigation at all for child pages
  • 404: the 404 page is not especially helpful. Only provides 2 links: previous page, and home page.

Aesthetics:

The post meta information appears to assume that posts will have only one (or very few) categories. It does handle many categories, but in so doing, makes the "comments" and "edit" links considerably less conspicuous, as they get lost visually in the long list of categories.

Note: See TracTickets for help on using tickets.