Opened 23 months ago

Closed 22 months ago

Last modified 22 months ago

#4438 closed theme (not-approved)

THEME: Plus social - 1

Reported by: morettolss Owned by: john_wdl
Priority: major Keywords: theme-plus-social
Cc: morettolss@…

Change History (7)

comment:1 Changed 22 months ago by emiluzelac

  • Owner set to john_wdl
  • Status changed from new to assigned

comment:2 Changed 22 months ago by john_wdl

Partial Review


Theme Check :

@Emil, Can you please check if these are problems?

RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( 'post-thumbnails' )in the functions.php file.
RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

INFO: single.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Line 4: <?php include (TEMPLATEPATH . '/sidebar2.php'); ?><!--sidebar 1-->

Line 12: <?php include (TEMPLATEPATH . '/inc/meta.php' ); ?><!--data autore-->

INFO: page.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Line 4: <?php include (TEMPLATEPATH . '/sidebar2.php'); ?><!--sidebar 1-->

Line 12: <?php include (TEMPLATEPATH . '/inc/meta.php' ); ?><!--data autore-->

INFO: index.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Line 4: <?php include (TEMPLATEPATH . '/sidebar2.php'); ?><!--sidebar 1-->

Line 12: <?php include (TEMPLATEPATH . '/inc/meta.php' ); ?> <!--data autore-->

INFO: archive.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Line 4: <?php include (TEMPLATEPATH . '/sidebar2.php'); ?><!--sidebar 1-->

Line 33: <?php include (TEMPLATEPATH . '/inc/nav.php' ); ?>

Line 41: <?php include (TEMPLATEPATH . '/inc/meta.php' ); ?>

Line 51: <?php include (TEMPLATEPATH . '/inc/nav.php' ); ?>

INFO: 404.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Line 4: <?php include (TEMPLATEPATH . '/sidebar2.php'); ?><!--sidebar 1-->

Line 12: <?php include (TEMPLATEPATH . '/inc/meta.php' ); ?><!--data autore-->


Debugg :

Undefined variable: max_page on line 55 of /wp-content/themes/plus-social/functions.php


Deprecated Calls :

Argument in get_bloginfo()
Used in wp-includes/general-template.php on line 372.


Theme Data Check :

No Tagline
Wide image overruns content area.
Clearing floats causes problems.
"Post with no title" not linked from homepage.
"Comments are closed." on posts with comments disabled.
SEO Links in footer


Recommendation : Not - Approved.

comment:3 Changed 22 months ago by emiluzelac

  • Resolution set to not-approved
  • Status changed from assigned to closed

Good review. Recommends and info above are highly suggested, however this is not a must. It's always good idea to include more information and details about this review from Theme Review page.

comment:4 Changed 22 months ago by morettolss

Sorry, but in http://codex.wordpress.org/Function_Reference/get_bloginfo i read "This function, as well as bloginfo(), can also be used to display your site information." The function is not deprecated, in the documentation is write "can also be used", and where i call this function?
Also i can not see that Tagline is mandatory.
Post with no title are links to the post form the right circle.
"Wide image overruns content area." the user can controll this, it can resize di image.

"@Emil, Can you please check if these are problems?"
There are problems?
And why can i use a deprecated functions? wordpress not return me errors, a deprecated functions not work.

comment:5 Changed 22 months ago by emiluzelac

Deprecated Calls :
Argument in get_bloginfo()
Used in wp-includes/general-template.php on line 372.
  • Does not refer to this or any other Theme, anything over wp-includes/ is WordPress? Core. Not sure how this can be, but it should be excluded from this review and feel free to disregard. Sorry for the inconvenience.
  • Items such as "INFO" and "RECOMMENDED" are only that and it should be treated as such.

Real Issues

  • Undefined variable: max_page on line 55 of /wp-content/themes/plus-social/functions.php

You can reproduce this variable with Debogger Plugin.

  • Theme Unit Check is something that is required, all items must display the way Theme Data indicates.

To recreate that, simply download and import Theme Unit Data and test against that. Pretty simple stuff really.

  • SEO Link, well it is true, http://www.chromeos.eu doesn't really have too much to do with WordPress?, but there is a "walk-around" that. Create a page i.e. http://www.chromeos.eu/themes and use that as your Credit Link. For an additional information about this, please see Credit Links guides.

All this should be an easy fix.

If you have any questions, please post theme here and one of us will assist you :)

Cheers,
Emil

P.S. I believe that reviewer had best intentions here, it's just that there is not enough of summary here, as well as much needed resources to help you out. He even asked me to check if they were problems or not.

Last edited 22 months ago by emiluzelac (previous) (diff)

comment:6 Changed 22 months ago by john_wdl

@ Emil,

That deprecated call only comes up when this theme is activated. So i posted it here thinking its something with this theme.

comment:7 Changed 22 months ago by emiluzelac

@john_wdl no harm done, explanation has been given :)

Last edited 22 months ago by emiluzelac (previous) (diff)
Note: See TracTickets for help on using tickets.