THEME: Elbee Elgee - 1.2

[ZaMoose]

Elbee Elgee - 1.2

An extremely flexible 1, 2, or 3 column theme with over 30 possible layouts and support for widgetized sidebars, custom headers, custom backgrounds, custom navigation menus, BuddyPress? and bbPress.

Theme URL - ​http://literalbarrage.org/blog/code/lblg
Author URL - ​http://literalbarrage.org/blog/

SVN - ​http://themes.svn.wordpress.org/elbee-elgee/1.2
ZIP - ​http://wordpress.org/extend/themes/download/elbee-elgee.1.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/elbee-elgee/1.1.1&new_path=/elbee-elgee/1.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-elbee-elgee&order=priority

[zamoose]

Responses to garinungkadol's previous review below.

Blog Post Index View
"REQUIRED: Posts with no titles must still include a permalink to the single post view. The recommended practice is to place the permalink on the post date as well." Fixed.
Single Post View
"REQUIRED: You must provide styling for heading elements (<h2> - <h6>), blockquotes, tables, definition lists, ordered lists and unordered lists." Fixed.
"REQUIRED: Captioned images must be properly aligned." Fixed.
"REQUIRED: Floated elements must be properly cleared." Fixed.
"REQUIRED: Check your styling of comments, particularly nested comments." Fixed.
"REQUIRED: Posts with closed comments are required to display some kind of "Comments are disabled" message. This does not apply to Pages." Fixed.
"RECOMMENDED: Theme options using textareas that allow HTML should use wp_kses_post when sanitizing form data." Fixed.

Visual issues / functionality / browser checks:

"Provide styling for the calendar widget." Fixed.
"Provide more whitespace between the post meta and post content." Moved meta info below post. Fixed.
"This is the display when Theme Stylesheet - layoutgala.css is chosen. Is this intentional? It looks like there is no style." Intentional. Demo stylesheet, now explicitly noted in README.markdown
"Content entered in "Copyright Statement" and "Footer Credits" does not show up on the site." Fixed.

"REQUIRED: wp_footer() must be placed directly before </body>." Fixed.
"REQUIRED: The use of $_SERVERPHP_SELF? in forms is discouraged as it presents a security risk." Fixed.
"REQUIRED: All custom functions and global variables must be prefixed with the theme slug or an appropriate variant." Fixed.
"REQUIRED: All data must be sanitized and validated before saving to the database and properly escaped when outputting to forms." Fixed.
"REQUIRED: Themes are required to use checked() and selected() for checkbox and select options in forms respectively." Fixed.
"Why is if ( ! isset( $content_width ) ) $content_width = '640'; entered twice in includes\supports.php?" Bug. Fixed.

"REQUIRED: Please note the license being used for your header images in the readme. They must be GPL-compatible." License terms noted in README. Fixed.

BuddyPress?/bbPress notes:
I have used the templates supplied by the BuddyPress? Template plugin and the core bbPress plugin to provide basic templating for those two plugins. In order to ease support and make sure I'm in compliance with the upstream codebases, I have provided only minimal differences with said codebases. Please consider allowing these portions through, as they are considered best-practice in BP and bbP, at least at this point. Perhaps once BP 1.3 finally ships and the next revision of bbP plugin is added, theming those two will be easier.

I look forward to (hopefully) my approval!

[garinungkadol]

Please assign to a BuddyPress?-savvy reviewer. That was the lacking item from the first review.

[zamoose]

mercime:
I've added a new version that addresses the flaws your images point out. It's over at #4982.

[mercime]

Thank you ZaMoose?. Will be checking it out.