THEME: Elbee Elgee - 1.2.1

[ZaMoose]

Elbee Elgee - 1.2.1

An extremely flexible 1, 2, or 3 column theme with over 30 possible layouts and support for widgetized sidebars, custom headers, custom backgrounds, custom navigation menus, BuddyPress? and bbPress.

Theme URL - ​http://literalbarrage.org/blog/code/lblg
Author URL - ​http://literalbarrage.org/blog/

SVN - ​http://themes.svn.wordpress.org/elbee-elgee/1.2.1
ZIP - ​http://wordpress.org/extend/themes/download/elbee-elgee.1.2.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/elbee-elgee/1.2&new_path=/elbee-elgee/1.2.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-elbee-elgee&order=priority

[mercime]

Issues from Previous Ticket

• Fixed. Floated elements must be properly cleared." Fixed.
• Fixed. Pages with comments closed should not have text "Comments Closed"
• Fixed. Content width for 3 column layout.
• Fixed. Support 3 column layout for native WP Gallery.
• Fixed. Add style for <h2> and <h3> elements = e.g. Page titles of Pages and Leave Reply text

BuddyPress?

My apologies for not including the following in previous review.

• REQUIRED. Please do not hardcode the links to BP Components [Activity, Members, Groups, Forums, and Blogs which is missing for MS installs]. Should user opt to disable component/s in BP settings, the hardcoded link/s will go to 404 page. See conditionals used in bp-default to prevent 404 from happening ​http://buddypress.trac.wordpress.org/browser/tags/1.2.9/bp-themes/bp-default/header.php#L51 . Or recommend replacing your current BP navigation with wp_nav_menu in preparation for BP 1.5 ​http://buddypress.trac.wordpress.org/browser/tags/1.5-beta-2/bp-themes/bp-default/header.php#L48

• REQUIRED. ​http://themes.svn.wordpress.org/elbee-elgee/1.2.1/members/single/activity/permalink.php - make it compatible with current BP 1.2.9 by replacing

<?php if ( bp_has_activities( 'display_comments=threaded&include=' . bp_current_action() ) ) : ?>

with

<?php if ( bp_has_activities( 'display_comments=threaded&show_hidden=true&include=' . bp_current_action() ) ) : ?>

Review Summary

Theme will be approved after revisions above have been made. Please post the URL to your new ticket here.

Thank you for your patience and for submitting Elbee Elgee to the WP theme repository.

[zamoose]

mercieme:
Thanks for the quick response. A couple of comments, if you please.

1) You didn't cite which files in my theme these REQUIREDs are relevant to, which makes hunting these issues down just a bit harder.

2) In re: your first point, I don't hard-code anything. You'll note that I register a second menu if I detect BP is active and then place default links to the various sections, but users are able to change those links at their leisure via the Menu interface.

3) In re: your second point, again, I'm not sure which of my files you're referring to, but the overwhelming majority of my BP support files come from the official BP Theme Compat plugin by the BP guys. I update my code when they do in order to keep things as simple and painless as possible. I can make the change you refer to, but that will make me deviate from the upstream codebase.

4) Is there a WPTRT section dealing with BP compat, or are the REQUIRED points you list above merely best practices that you've found while reviewing BP-supporting themes? I ask because it makes this process akin to shooting in the dark if the answer to that question is "No, there's not WPTRT guidelines for BP themes".

If it's alright with you, I'll hold off on making any changes until you get a chance to review these comments.

Thanks!

[mercime]

Replying to zamoose:

mercieme:
Thanks for the quick response. A couple of comments, if you please.

1) You didn't cite which files in my theme these REQUIREDs are relevant to, which makes hunting these issues down just a bit harder.

2) In re: your first point, I don't hard-code anything. You'll note that I register a second menu if I detect BP is active and then place default links to the various sections, but users are able to change those links at their leisure via the Menu interface.

I stand corrected here. Thank you for pointing this out. The 2nd wp_nav_menu when BP is activated didn't show up in my test install. After you posted here, I double-checked by uploading your theme to a new test install and I now see the your new "Default BuddyPress? Menu" in Menus.
Note: Both test installs are multisite, the difference was that in the first test install, BP is installed in secondary blog.

3) In re: your second point, again, I'm not sure which of my files you're referring to, but the overwhelming majority of my BP support files come from the official BP Theme Compat plugin by the BP guys. I update my code when they do in order to keep things as simple and painless as possible. I can make the change you refer to, but that will make me deviate from the upstream codebase.

When you first submitted your theme almost 2 months ago, BP Template Pack plugin aka BP Compat plugin by the BP Devs Andy Peatling and Boone Gorges was version 1.1.3. No deviation being pushed. The change I pointed out to you is per diff of BP Template Pack plugin version 1.1.3 to version 1.1.4 which came out while your theme was being reviewed ​http://wordpress.org/extend/plugins/bp-template-pack/installation/

4) Is there a WPTRT section dealing with BP compat, or are the REQUIRED points you list above merely best practices that you've found while reviewing BP-supporting themes? I ask because it makes this process akin to shooting in the dark if the answer to that question is "No, there's not WPTRT guidelines for BP themes".

No there is no WPTRT guidelines specifically for BP themes. BP themes are reviewed the same as WP themes are. For BP, extra checks on deprecated template tags, functions, and all that jazz are implemented. Important point is that any BP child/parent theme submitted to the WP repo should be compatible with the current BP version.

If it's alright with you, I'll hold off on making any changes until you get a chance to review these comments. Thanks!

Sure thing. No one's infallible, least of all myself :-)

Thank you and have a good evening.

Mercime

[zamoose]

Mercime:
#5061 is up and live and has the requested fix you outlined for full BP 1.2.9 compatibility.