THEME: DePo Masthead - 1.0.2

[automattic]

DePo? Masthead - 1.0.2

A classy template that draws on classic magazine design for a simple, bold style.

Theme URL - ​http://wordpress.org/extend/themes/depo-masthead/
Author URL - ​http://automattic.com/

SVN - ​http://themes.svn.wordpress.org/depo-masthead/1.0.2
ZIP - ​http://wordpress.org/extend/themes/download/depo-masthead.1.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/depo-masthead/1.0.1&new_path=/depo-masthead/1.0.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-depo-masthead&order=priority

---

PREVIOUS ISSUES - FAIL:

• Custom pagination functions/ lack of WP functions - PARTIALLY FIXED (previous_posts_link() and next_posts_link() are now being used in index.php, however the main blog index is using home.php which does not provide a means of pagination).
• Inconsistent function prefixes - NOT FIXED (functions still using both depomasthead and depo prefix, please pick one).
• PHP errors - NOT FIXED (although there are not as many as before, there are still several PHP errors - see DEBUGGING notes further down the page).
• Missing license.txt - NOT FIXED
• Lack of documentation/readme file - NOT FIXED

---

DEBUGGING - FAIL:

• Debug: Undefined variable: title on line 63 of /wp-content/themes/depo-masthead/header.php
• Debug: Undefined index: preview on line 11 of /wp-content/themes/depo-masthead/home.php

---

THEME CHECK - FAIL:

• WARNING: .ds_store Hidden Files or Folders found.
• RECOMMENDED: could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
• RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( 'post-thumbnails' )in the functions.php file.
• RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

---

VALIDATION

CSS - PASS
HTML - 1 ERROR:

158	359	 …"http://orangeola.com/themeclean/about/">Continue reading &raquo;</a>	 </div>	end tag for "p" omitted, but OMITTAG NO was specified

---

THEME UNIT TEST - FAIL

• Page navigation not displaying on layout test on blog posts index page.
• Correct number of posts does not display (as per setting in Settings > Reading).
• Floats not clearing properly on Images Test > Clearing Floats (screenshot)
• Post Format Test - Image (Linked) cuts off (screenshot)

---

CODE QUALITY

• Please delete lines 46 ad 47 of comments.php, they are no longer required and are now a security risk. (see ​Mark Jaquith's post)
• wp_head(); is to be called directly before the </head> tag.
• Do not hard-code scripts directly in the header, instead enqueue and hook them into the wp_head function.
• As mentioned in the previous ticket, please use a consistent prefix for your functions.

---

I concur with pseudoxiah that the existing home.php should become front-page.php and home.php should include the traditional page navigation. Or perhaps that particular layout should become a theme option instead of the default, as this particular layout does not comply with the Theme Unit Test standards.

Also, there were a significant number of previous issues that were not resolved. Please ensure that all issues are resolved before re-submitting.

INFORMATION:

• This is a complete review. If there are any issues once resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.
• Note: Re-submitted Themes are given review priority over new Themes.
• You can use the following tools to recreate the issues raised above if any have been:
  • Theme Check Plugin: ​http://wordpress.org/extend/plugins/theme-check/
  • Theme Unit Test: ​http://codex.wordpress.org/Theme_Unit_Test
  • Log Deprecated Notices: ​http://wordpress.org/extend/plugins/log-deprecated-notices/
• Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
• You can also view the Theme Review page.
• Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:
  • 1) Leave a comment on this ticket
  • 2) Email the theme-reviewers email list
  • 3) Use the #wordpress-themes channel on irc.freenode.ne

See also: ​Theme Review

Recommended Action for this theme: NOT-APPROVED

---