THEME: Admired - 1.0.1

[bradthomas127]

Admired - 1.0.1

The Admired theme is a stylish and fully customizable WordPress? theme. Make it yours with the easy customizable theme options with a simple check-box interface to easily change colors, fonts, skins, menus, sidebars, and much more. Uses Superfish menu effects and it has built-in pagination for post pages. It has special styles for six different post formats and an option to show post excerpts with thumbnails. Admired also has a HTML sitemap template, four extra widgets, and Google fonts.

Theme URL - ​http://wp-ultra.com/admired/
Author URL - ​http://wp-ultra.com/

SVN - ​http://themes.svn.wordpress.org/admired/1.0.1
ZIP - ​http://wordpress.org/extend/themes/download/admired.1.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/admired/1.0&new_path=/admired/1.0.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-admired&order=priority

[john_wdl]

This is a partial review :

---

Theme Check : Pass

---

Deprecated Calls : None

---

Theme Unit Test

Long string in sub menu is overflowing the container. Check Attachment
Video overflows content area when i select 3 column layout. Check Attachment
Logo disappeared on setting some options in "header" section of ultra panel.

---

Recommendation : Approved (Pending code quality check by saymar90 and minor issues mentioned above)

---

[bradthomas127]

@john_wdl - I have the first two issues fixed, can i ask what browser the logo is disappearing in? I haven't been able to replicate it. Should i resubmit the theme when fixed or wait for the code quality check?

[john_wdl]

It happened in FF, i left the logo url field empty in header section of options panel and saved the options. The text "My Blog" which was there in header earlier disappeared.

I think you should do a !empty check for that field?

I think you should wait for code quality check results before you create a new ticket, will save you time.

[bradthomas127]

I'm still not able to replicate it, you didn't have the hide site title and description option checked did you?

[john_wdl]

My bad, you can ignore that issue :)

[bradthomas127]

@saymar90 - Is their anything else or can i upload the fixed version?

[saymar90]

• Wide image resized in editor is resized incorrectly. See wide-image-resized-in-editor.png
• Video don't work with me. See Post-Format-Test_-Video.png
• For code quality. Just a recommendation : Use get_template_part() instead of require_once()

[bradthomas127]

@saymar90 - The reason I am not using get_template_part() on the widgets is because they are in a sub-directory. I have been watching this ticket though on hopes that they implement a safe way of doing it in WP version 3.3: ​http://core.trac.wordpress.org/ticket/15086

I cant figure out why the post video is not working on your end, you can see in john_wdl attachment admired2.png it was working for him too. and here is a screenshot from how im seeing it: ​http://awesomescreenshot.com/003n8luae

Everything else i have fixed now can i re-upload?

[saymar90]

@bradthomas127: Yes, you can...

[bradthomas127]

@saymar90 and @john_wdl - Thanks for the reviews.

Here is the new ticket: http://themes.trac.wordpress.org/ticket/5699

[saymar90]

The review will continue in the new ticket.