THEME: Trending - 0.2.1

[greenshady]

Trending - 0.2.1

A theme for bloggers that uses multiple nav menus, several sidebars, and custom post layouts. It has a pixel-perfect design that's great for any blogger who wants a new look for their site.

Theme URL - ​http://themehybrid.com/themes/trending
Author URL - ​http://justintadlock.com

SVN - ​http://themes.svn.wordpress.org/trending/0.2.1
ZIP - ​http://wordpress.org/extend/themes/download/trending.0.2.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/trending/0.2&new_path=/trending/0.2.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-trending&order=priority

[garinungkadol]

REVIEW SUMMARY

• Theme is already approved
• No outstanding issues from previous ticket.
• Diff. check shows minor changes - removed filter for comment class.
• Performed complete review and identified the following which can be fixed in an upcoming release:
  • REQUIRED: Preventing direct access to the comments template is no longer needed. You can remove Lines 12 - 14 in comments.php
  • RECOMMENDED: Check how trackbacks are displayed when gravatars are enabled. See trackbacks-gravatars-enabled.jpg

RECOMMENDATION: APPROVED

[greenshady]

• REQUIRED: Preventing direct access to the comments template is no longer needed. You can remove Lines 12 - 14 in comments.php

Please provide source where this is now a requirement.

I agree the code usage doesn't matter for this particular template. I'm just interested in reading the discussion and guidelines set for this requirement.

[garinungkadol]

Replying to greenshady:

• REQUIRED: Preventing direct access to the comments template is no longer needed. You can remove Lines 12 - 14 in comments.php

Please provide source where this is now a requirement.

I agree the code usage doesn't matter for this particular template. I'm just interested in reading the discussion and guidelines set for this requirement.

I'm going to get clarification on this. I remember there was a discussion about security and the user of $_SERVER variable but I can't find the exact discussion right now.