THEME: GroundWork - 1.0

[bhadaway]

GroundWork? - 1.0

GroundWork? is the groundwork already prepared for any website, mobile site, social network, blog or forum. A responsive framework to jumpstart any project.

Theme URL - ​http://calmestghost.com/groundwork/
Author URL - ​http://calmestghost.com/

SVN - ​http://themes.svn.wordpress.org/groundwork/1.0
ZIP - ​http://wordpress.org/extend/themes/download/groundwork.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-groundwork

[saymar90]

Suggest

Not approved.

Theme Check Recommended

• Could not find the file readme.txt in the theme. Please see ​Theme_Documentation for more information.
• No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
• No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• No reference to add_custom_background() was fo

Layout

• Wide image overflows the content. See attachment wide-image.png.
• Provide more style for table, definition lists and widget areas. See table.png, definition-list.png and Page-with-all-widgets-areas-actived.png.
• Add correct style for html tags sub and sup.
• Clearing floats don't work. See Clearing-floats-page.png.
• Previous or Next image links don't display to image page.
• Bottom menu don't display correctly. See attachment bottom-menu.png.

Code Quality

• If incorporated into the Theme, custom template files are required to be called using ​get_template_part() or ​locate_template()
  • See here for additional information: ​How To Load Files Within WordPress Themes
  • include( TEMPLATEPATH . '/file.php' ) must not be used to call Theme template part files.
• Since you use __(); or _e(); your theme support translation. You should internationalize all text in the theme. If you don't want to support translation just remove all __() or _e().

[bhadaway]

• Previous or Next image links don't display to image page.

I think perhaps you made a mistake on this one or I'm misunderstanding? Both Post Format Test: Gallery and Layout Test which are the surrounding posts (at least on my setup) link to it just fine.

• If incorporated into the Theme, custom template files are required to be called using get_template_part() or locate_template()

See here for additional information: How To Load Files Within WordPress? Themes
include( TEMPLATEPATH . '/file.php' ) must not be used to call Theme template part files.

• Since you use (); or _e(); your theme support translation. You should internationalize all text in the theme. If you don't want to support translation just remove all () or _e().

Not sure what to do specifically for either of these.

Thanks, Bryan

[saymar90]

Replying to bhadaway:

• Previous or Next image links don't display to image page.

I think perhaps you made a mistake on this one or I'm misunderstanding? Both Post Format Test: Gallery and Layout Test which are the surrounding posts (at least on my setup) link to it just fine.

You are misunderstanding. When we are in Post Format Test: Gallery and you click on an image, you go to attachment page but previous and next image links should display like previous and next post links on single post page.

• If incorporated into the Theme, custom template files are required to be called using get_template_part() or locate_template()

See here for additional information: How To Load Files Within WordPress? Themes
include( TEMPLATEPATH . '/file.php' ) must not be used to call Theme template part files.

You should use get_template_directory() instead of TEMPLATEPATH

• Since you use (); or _e(); your theme support translation. You should internationalize all text in the theme. If you don't want to support translation just remove all () or _e().

You should internationalize all text in the theme ie if you have Archives you should <?php _e( 'Archives', 'groundwork' ); ?> instead of or if you don't want to support translation just remove all _e(); and __(); functions.

[bhadaway]

You are misunderstanding. When we are in Post Format Test: Gallery and you click on an image, you go to attachment page but previous and next image links should display like previous and next post links on single post page.

Is there an example of this somewhere, both in demo and code? I've actually never seen or even heard of this WordPress? feature before.

Thanks, Bryan

[bhadaway]

http://themes.trac.wordpress.org/ticket/9868 - Better late than never :).