THEME: WSC7 - 1.0

[imai5]

WSC7 - 1.0

WSC Project, Very simple theme. Markup of css which can facilitate customization. Using the CSS media queries, change the screen size.

Theme URL - ​http://www.studiobrain.net/wsc
Author URL - ​http://www.studiobrain.net/

SVN - ​http://themes.svn.wordpress.org/wsc7/1.0
ZIP - ​http://wordpress.org/extend/themes/download/wsc7.1.0.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/wsc7/0.2.3&new_path=/wsc7/1.0

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-wsc7&order=id

[Mamaduka]

Previous Ticket Issues

• Prefix new_excerpt_more() function. This function was removed. (fixed)
• Display wp_head() immediately before </head>. Previous issue was fixed, but introduced new one. (not-fixed)
• Missing text domains. (not-fixed)
• Include header images properly via add_custom_image_header(). (fixed)

header.php

• As mentioned above and previous review, wp_head() tag should be called immediately before the closing HTML head tag.
• wp_enqueue_script('jquery') was called directly in header.php, this function should be hooked into appropriate hook via callback function. Recommended hooks is wp_enqueue_scripts.
• Remove JS inserted after wp_head() tag. If JS is inserted inline, between <script> tags, it should be added properly with /* <![CDATA[ */ - /* ]]> */ to pass HTML validator. As your script doesn't need any user generated data, you can place it in separated js file and enqueue with jQuery.

Theme Unit Tests

• Post with no title need link to single page view.
• Fixed sidebar is buggy - if sidebar height is big it's got hidden, and there is no way to view those widgets, also can't click links if content is scrolled a bit.

Other Notes

• add_custom_image_header() doesn't require any callback, so admin_header_style() empty fallback can be removed, also any functions introduced by theme should be prefixed, preferably by theme-slug.
• Themes are required to use theme-slug as textdomain for translation. See ​http://codex.wordpress.org/Theme_Review#Theme_Namespacing

Suggested Resolution

not-approved