THEME: Bere Elegant - 3.1

[bernabe.ber]

Bere Elegant - 3.1

A elegant, minimal theme. Wordpress 3.2.1 ready.

Theme URL - ​http://www.bernabefuentes.com/desarrollo-web/bere-elegant-tema-para-wordpress/
Author URL - ​http://www.bernabefuentes.com

SVN - ​http://themes.svn.wordpress.org/bere-elegant/3.1
ZIP - ​http://wordpress.org/extend/themes/download/bere-elegant.3.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/bere-elegant/3.0&new_path=/bere-elegant/3.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-bere-elegant&order=id

[kobenland]

THEME REVIEW RESULTS

• Previous version of Theme NOT-APPROVED

Previous Issues from #6885

• FIXED: Theme URI is not appropriate. It is both a "generic" URL (i.e. not specific to this Theme), and also is merely a demo of the Theme.

• Still not fixed:
  • All Theme-defined functions must be custom-prefixed
  • Scripts and stylesheets must be enqueued rather than hard-coded in the HTML document head
  • Must use core-bundled version of jQuery. Version linked in document head is outdated
  • jQuery scripts must use no-conflict syntax
  • Navigation menus are required to support core custom navigation menu functionality
  • All public-facing text must be in English, with translation support provided for other languages, if needed
  • Translation support is only partially implemented

Review Summary

• Diff review only
• Theme has required issues (see above)
• Ticket being resolved as NOT-APPROVED. Please address required issues in next Theme revision.

Please note: (copied in parts from SeizedPropaganda?)

• Theme will be held for approval until items listed as REQUIRED are addressed. Once these issues have been resolved, please re-submit your Theme using ​the uploader tool on wordpress.org, and a new Trac ticket will be generated.

• Re-submitted Themes are given review priority over new Themes. Any review-based Theme revision that is submitted within two days of the previous review and linked to from the previous ticket will be accepted by the previous-ticket reviewer, and the review continues on the new ticket.

• The Theme Review Team will no longer emphasize complete and thorough reviews, and will instead close tickets upon observation of any non-trivial issues.

• Please use the following tools to recreate the issues raised above:
  • Theme Check Plugin: ​http://wordpress.org/extend/plugins/theme-check/
  • Theme Unit Test: ​http://codex.wordpress.org/Theme_Unit_Test
  • Log Deprecated Notices: ​http://wordpress.org/extend/plugins/log-deprecated-notices/

• Themes should be reviewed using define( 'WP_DEBUG', true ); in wp-config.php

• You should also view ​the Theme Review page.

• Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:
  1. Leave a comment on this ticket
  2. Email the theme-reviewers email list
  3. Use the #wordpress-themes channel on irc.freenode.net

[bernabe.ber]

I do not understand this:
. All Theme-defined functions must be custom-prefixed
. Scripts and stylesheets must be enqueued rather than hard-coded in the HTML document head

Can you give me some example?.

[kobenland]

Themes are required to prefix all options, custom functions, custom variables, and custom constants with theme-slug (or appropriate variant).
Bad: admin_header_style()
Good: bere_elegant_admin_header_style()

Enqueue Scripts like so:

<?php
function bere_elegant_scripts() {
   // enqueue your script with location, dependencies and version
   wp_enqueue_script('custom_script',
       get_template_directory_uri() . '/js/custom_script.js',
       array('jquery'),
       '1.0' );
}
add_action( 'wp_enqueue_scripts', 'bere_elegant_scripts' );

See the Codex for reference.

[bernabe.ber]

I do not understand this:

. Navigation menus are required to support core custom navigation menu functionality
.All public-facing text must be in English, with translation support provided for other languages, if needed
. Translation support is only partially implemented

Can you give me some example?.

[kobenland]

Please consult the Codex first for questions on ​Theme Development and ​Theme Review Guidelines.