THEME: technic - 1.011

[Netclosing]

technic - 1.011

This technic Version 1.012 Theme is stylish, customizable, simple, and readable. It includes stylesheets for print and the admin Visual Editor, special styles for posts in the "Asides" and "Gallery" categories, and has an optional one-column page template that removes the sidebar.

Theme URL - ​http://technic.wv.to
Author URL - ​http://www.netclosing.de

SVN - ​http://themes.svn.wordpress.org/technic/1.011
ZIP - ​http://wordpress.org/extend/themes/download/technic.1.011.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/technic/1.01&new_path=/technic/1.011

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-technic&order=id

[saymar90]

Last Review

Not fixed : Theme Check

• Text domain problems in widget-techblog-twitter.php. You have not included a text domain!

  Line 25: 'description' => __( 'Displaying recent Tweets from a designated Twitter account.' )
  

• Text domain problems in widget-techblog-text.php. You have not included a text domain!

  Line 22: 'description' => __('Techblog Theme Arbitrary text or HTML'));
  

• Text domain problems in widget-techblog-tag-cloud.php. You have not included a text domain!

  Line 22: 'description' => __( 'Techblog Theme most used tags in cloud format') );
  Line 66: <p><label for='<?php echo $this->get_field_id('title'); ?>'><?php _e('Title:') ?></label>
  Line 68: <p><label for='<?php echo $this->get_field_id('taxonomy'); ?>'><?php _e('Taxonomy:') ?></label>
  

• Text domain problems in widget-techblog-rss.php. You have not included a text domain!

  Line 22: 'description' => __('Techblog Theme Entries from any RSS or Atom feed') );
  Line 59: $title = empty($desc) ? __('Unknown Feed') : $desc;
  

• Text domain problems in widget-techblog-recent-post.php. You have not included a text domain!

  Line 21: 'description' => __( 'The most recent posts on your techblog theme'));
  Line 46: $title = apply_filters('widget_title', empty($instance['title']) ? __('Recent Posts') : $instance['title'], $instance, $this->id_base);
  

• Text domain problems in widget-techblog-recent-comments.php. You have not included a text domain!

  Line 19: //$widget_ops = array('classname' => 'widget_recent_comments', 'description' => __( 'The most recent comments of techblog theme' ) ); //NOTE- change all  
  Line 22: 'description' => __( 'The most recent comments of techblog theme' ) );
  Line 61: $title = apply_filters('widget_title', empty($instance['title']) ? __('Recent Comments') : $instance['title']);
  

• Text domain problems in widget-techblog-popular-posts.php. You have not included a text domain!

  Line 24: 'description' => __( 'The most popular posts on techblog theme') );
  Line 47: $title = apply_filters('widget_title', empty($instance['title']) ? __('Popular Posts') : $instance['title'], $instance, $this->id_base);
  

• Text domain problems in widget-techblog-pages.php. You have not included a text domain!

  Line 20: //$widget_ops = array('classname' => 'widget_pages', 'description' => __( 'A list of techblog theme website’s pages') );
  Line 23: 'description' => __( 'A list of techblog theme website’s pages') );
  Line 30: $title = apply_filters('widget_title', empty( $instance['title'] ) ? __( 'Pages' ) : $instance['title'], $instance, $this->id_base);
  

• Text domain problems in widget-techblog-meta.php. You have not included a text domain!

  Line 19: //$widget_ops = array('classname' => 'widget_meta', 'description' => __( 'Log in/out, admin, feed and Techblog Theme links') );
  Line 28: $title = apply_filters('widget_title', empty($instance['title']) ? __('Meta') : $instance['title'], $instance, $this->id_base);
  Line 40: <li><a href='<?php bloginfo('rss2_url'); ?>' title='<?php echo esc_attr(__('Syndicate this site using RSS 2.0')); ?>'><?php _e('Entries <abbr titl
  Line 41: <li><a href='<?php bloginfo('comments_rss2_url'); ?>' title='<?php echo esc_attr(__('The latest comments to all posts in RSS')); ?>'><?php _e('Comments <ab
  Line 42: <li><a href='http://wordpress.org/' title='<?php echo esc_attr(__('Powered by WordPress, state-of-the-art semantic personal publishing pl
  

• Text domain problems in widget-techblog-links.php. You have not included a text domain!

  Line 21: //$widget_ops = array('description' => __( 'Techblog Theme Blogroll' ) );
  Line 39: echo $before_widget . $before_title. __('All Links') . $after_title . $after_widget;
  

• Text domain problems in widget-techblog-costum-menu.php. You have not included a text domain!

  Line 19: //$widget_ops = array( 'description' => __('Use this widget to add one of techblog theme custom menus as a widget.'
  Line 22: 'description' => __('Use this widget to add one of techblog theme custom menus as a widget.'
  Line 73: <label for='<?php echo $this->get_field_id('title'); ?>'><?php _e('Title:') ?></label>
  

• Text domain problems in widget-techblog-calender.php. You have not included a text domain!

  Line 21: //$widget_ops = array('classname' => 'widget_calendar', 'description' => __( 'A techblog theme calendar of your site’s posts') );
  Line 24: 'description' => __( 'A techblog theme calendar of your site’s posts') );
  

• Text domain problems in widget-techblog-archive.php. You have not included a text domain!

  Line 21: //$widget_ops = array('classname' => 'widget_archive', 'description' => __( 'A techblog theme monthly archive of your site’s posts') );
  Line 24: 'description' => __( 'A techblog theme monthly archive of your site’s posts') );
  Line 32: $title = apply_filters('widget_title', empty($instance['title']) ? __('Archives') : $instance['title'], $instance, $this->id_base);
  Line 43: <select name='archive-dropdown' onchange='document.location.href=this.options[this.selectedIndex].value;'> <option value=''><?php echo esc_attr(__('Select Month')); ?></option> <?php wp_get_archives(apply_filters('widg
  

• Text domain problems in functions.php. You have not included a text domain!

  Line 248: return ' <a href=''. get_permalink() . ''>' . __( '') . '</a>';
  Line 377: 'name' => __( 'Index Right Side Widget'),
  Line 379: 'description' => __( 'The index page right side widget area'),
  Line 388: 'name' => __( 'Category Widget Area'),
  Line 390: 'description' => __( 'The category widget area'),
  Line 400: 'name' => __( 'Page Widget Area'),
  Line 402: 'description' => __( 'The pages right side widget area'),
  Line 411: 'name' => __( 'Post Widget Area'),
  Line 413: 'description' => __( 'The post page widget area'),
  Line 423: 'name' => __( 'Search, Archive Widget' ),
  Line 425: 'description' => __( 'The search, archive and tags pages widget'),
  Line 436: 'name' => __( 'Footer Widget Areassss' ),
  Line 438: 'description' => __( 'The main footer widget area'),
  Line 448: 'name' => __( 'Subscribers and Twitter User'),
  Line 450: 'description' => __( 'The Subscribers and twitter user name for counter'),
  Line 726: 'categorize' => 1, 'title_li' => __('Bookmarks'),
  

• header.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

  Line 3: include( TEMPLATEPATH . '/xj/class.php' );
  

Debug errors

• Undefined index: categories on line 28 of ..\wp-content\themes\technic\widgets\widget-techblog-category.php
• Undefined variable: user_title on line 73 of ..\wp-content\themes\technic\widgets\widget-techblog-category.php

Layout

• Image alignment don't work. Only fixed for image with no caption
• Gallery don't display properly. Not Fixed
• Categories don't display on post with many categories. Not Fixed
• Previous or Next Post links don't display to single page. Not Fixed
• Not Fixed: It remains for widget lists. Provide more style for lists. See ​lists.png, ​lists-comments.png and ​ol-list.png.
• Menu don't display correctly. See attachment ​menu.png. Fixed
• Provide more style for widget. See ​widget-footer-pages.png and ​widget-lists.png. Not fixed
• ​widget-popular-posts.png don't work properly. Not Fixed: See it in footer
• Provide more style for ​comments.png Not Fixed
• Provide more style for ​footer.png Not Fixed
• Provide more style for ​table.png Not Fixed
• Single attachment page don't display correctly. See attachment ​image-page.jpg. Fixed
• Somes images and video are overflow the content. See ​Post-format-test-image-linked.jpg, ​video.png and ​wide-image.png. Fixed
• When there are no social media set, this box should not appear. See attachment ​social.png. Not Fixed
• Page navigation links don't display properly. Not Fixed

Code Quality

• Themes are required to use a unique slug as a prefix for all custom function names, classes, public/global variables, database entries (Theme options, post custom metadata, etc.)
  • Themes are recommended to use theme-slug as this unique slug. You should remove all Twenty_Ten and Twenty Ten.
• wp_footer() is required to be included immediately before </body>.
• If incorporated into the Theme, custom template files are required to be called using get_template_part() or locate_template(), include( TEMPLATEPATH . '/file.php' ) must not be used to call Theme template part files.
• Theme is required to enqueue all stylesheets and scripts, using ​wp_enqueue_style()/​wp_enqueue_script(), and hooked into an appropriate hook via callback function, rather than hard-coding stylesheet/script links or tags in the template.
• Theme is required to support the following WordPress?-defined CSS classes, or similar elements:
  • Alignment Classes: .aligncenter, .alignleft, .alignright
  • Caption Related Classes: .wp-caption, .wp-caption-text, .gallery-caption
• Theme is required to validate and sanitize all untrusted data before entering data into the database, and to escape all untrusted data before being output in the Settings form fields or in the Theme template files (see: ​Data Validation)
• Theme is required to prefix all options, custom functions, custom variables, and custom constants with theme-slug (or appropriate variant).
• Theme is required to save options in a single array, rather than create multiple options for its settings page. Use of set_theme_mod and get_theme_mod handles this for you, as does using the Settings API.
• Theme is required to provide end-user documentation of any design limitations or extraordinary installation/setup instructions. It should be mentioned in readme.txt, dropdown menu are not supported.
• Since you use __(); or _e(); your theme support translation. You must internationalize all text in the theme. If you don't want to support translation just remove all __() or _e() .

Notes: I have just done revision for Theme Check section and Layout, please make sure you have fixed a lot of issues before resubmit...