THEME: Fanwood - 0.1.6.4

[tungdo]

Fanwood - 0.1.6.4

All-purpose, responsive (mobile friendly) theme with 12 optional layouts, per post layouts, multiple drop down menus, 18 widget areas, support for all 10 post formats, mobile compatible menus, and integrations for bbPress, BuddyPress?, Jigoshop, and Hybrid Tabs.

Theme URL - ​http://devpress.com/themes/fanwood
Author URL - ​http://devpress.com

SVN - ​http://themes.svn.wordpress.org/fanwood/0.1.6.4
ZIP - ​http://wordpress.org/extend/themes/download/fanwood.0.1.6.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/fanwood/0.1.6.3&new_path=/fanwood/0.1.6.4

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-fanwood&order=id

• License provided for packaged fonts
• TEMPLATEPATH replaced with get_template-directory
• Prefix added to necessary items. Unchanged functions cannot be prefixed due to being a part of the Hybrid Core framework
• textdomain problem fixed

Just realized I can upload attachments after logging to trac instead of changing the theme version number to submit the edited version.

I couldn't login earlier so there was no way for me to submit modifications via trac.

@tungdo, while you can attach attachments to tickets, we can't do anything with those attachments. All Theme revisions must be submitted using the Theme uploader, thereby creating a new ticket. Unfortunately, that is one of the limitations of our infrastructure.

Required

• License statement in style.css:
  • This is a license statement: Copyright (c) 2012 Tung Do. All rights reserved. Change "all rights reserved" to a GPL reference
• H2 tags do not clear floats. Is this by design? (See page 2 of Post Format Test: Gallery post)
• Post Format Test: Linked Image - nothing displays for post content/excerpt in post-index view
• Theme Settings: I cannot get the header search form(s) to display, no matter the menu settings.
• Widgets: PHP notices:
  • Undefined index: exclude in .../wp-content/themes/fanwood/library/classes/widget-pages.php</b> on line 62
  • Undefined index: exclude in .../wp-content/themes/fanwood/library/classes/widget-pages.php</b> on line 62
  • Undefined index: authors in .../wp-content/themes/fanwood/library/classes/widget-pages.php</b> on line 65
  • Undefined index: authors in .../wp-content/themes/fanwood/library/classes/widget-pages.php</b> on line 65

These are the things I found in a normal review. Pending BuddyPress? review.

Chip,

Just adding issues found in previous version which have not been corrected in this version.

Theme Unit Test

• Layout Test = Uneven vertical spacing for Unordered and Ordered Lists
• Comments Test = Uneven vertical spacing for Unordered and Ordered Lists

Deprecated Notice

• Function: add_contextual_help() Used in wp-content/themes/fanwood/library/admin/theme-settings.php on has been deprecated in WP 3.3. Use get_current_screen()->add_help_tab() instead.

BP Activity Stream

• Favoriting (*heart*) an activity update leads to 404 page in all activity streams.

Removing Default Widgets

• Please do not remove/replace default "Recent Posts" widget with your own "Recent Networkwide Posts" widget as some will just want links to Recent Posts in the main blog instead of Recent Network Posts (which show up clunky in the sidebar including excerpts and thumbnails and a blank large space where video should have been)

Stopped review at this time pending fix of issues listed above.
Mercime

I will hold this ticket open for two days, to allow time to address the required issues listed above. Once you have uploaded a Theme revision, add a comment here with a link to the new ticket, and the review will continue in the new ticket.

thanks chip and mercime. some of the issues, i probably won't be able to update within 2 days, but will try.

Just keep me posted on your progress. I don't mind holding it open for a bit, as long as I know you're working through the issues.

Hi Chip. We're updating this theme, however, will have to wait on Justin to get around to fixing the PHP notices from the Hybrid Core framework. You may close this ticket now if necessary.

No problem. Just re-submit when you're ready!

Hi Tungdo,

Apologies for the delay.

RE: BP ACTIVITY STREAMS - Mark as Favorite issue

In order to be able to mark an activity as favorite, there must be activity_entry_content already generated. Moving

<?php if ( bp_activity_can_favorite() ) : ?>
	<?php if ( !bp_get_activity_is_favorite() ) : ?>
		<a href="<?php bp_activity_favorite_link(); ?>" class="button fav 

bp-secondary-action" title="<?php esc_attr_e( 'Mark as Favorite', 'buddypress' ); ?>"><?php _e( 'Favorite', 'buddypress' ) 

?></a>
	<?php else : ?>
		<a href="<?php bp_activity_unfavorite_link(); ?>" class="button unfav 

bp-secondary-action" title="<?php esc_attr_e( 'Remove Favorite', 'buddypress' ); ?>"><?php _e( 'Remove Favorite', 

'buddypress' ) ?></a>
	<?php endif; ?>
<?php endif; ?>

to just under the following activity_content block in your theme's activity/entry.php file

<?php if ( bp_activity_has_content() ) : ?>
	<div class="activity-inner">
		<?php bp_activity_content_body(); ?>
	</div>
<?php endif; ?>
<?php do_action( 'bp_activity_entry_content' ); ?>

corrects the issue of 404 error. In effect, you can move the whole Activity Meta group to after the activity_entry_content block like that of BuddyPress?' default activity stream block and use CSS to fix positioning of the Activity Meta.

RE: BP TEMPLATE PACK plugin

An unsolicited suggestion: Since you already have all the BP template files within the 6 BP folders in your Fanwood theme and you do not even use stylesheet provided in BP Template Pack plugin, you can skip the need/requirement to install and activate the BP Template Pack plugin by adding the following to your functions.php file:

Take advantage of bp-default's AJAX and JS

// Include AJAX handlers
include( BP_PLUGIN_DIR . '/bp-themes/bp-default/_inc/ajax.php' );

// Enqueue bp-default's JS and localize
function fanwood_enqueue_bp_default_js() {
	wp_enqueue_script( 'dtheme-ajax-js', BP_PLUGIN_URL . '/bp-themes/bp-default/_inc/global.js', array( 'jquery' ) );

	$params = array(
		'my_favs'           => __( 'My Favorites', 'buddypress' ),
		'accepted'          => __( 'Accepted', 'buddypress' ),
		'rejected'          => __( 'Rejected', 'buddypress' ),
		'show_all_comments' => __( 'Show all comments for this thread', 'buddypress' ),
		'show_all'          => __( 'Show all', 'buddypress' ),
		'comments'          => __( 'comments', 'buddypress' ),
		'close'             => __( 'Close', 'buddypress' ),
		'view'              => __( 'View', 'buddypress' ),
		'mark_as_fav'	    => __( 'Favorite', 'buddypress' ),
		'remove_fav'	    => __( 'Remove Favorite', 'buddypress' )
	);
	wp_localize_script( 'dtheme-ajax-js', 'BP_DTheme', $params );
}
add_action( 'wp_enqueue_scripts', 'fanwood_enqueue_bp_default_js' );

Thank you for supporting BuddyPress? in your theme.

Mercime

Hi Mercime. I will test it this weekend and fix other issues as well. Thank you for your help.

Hi Tungdo,

Additional observation: In Appearance > Theme Settings > Layouts

• For Global, bbPress, BuddyPress? and Jigoshop Layouts == when I select "layout_1c" and click on "Update Settings" button, the selection goes back to "layout_default". All other selections stay on the selected layout when I save settings except layout_1c. Despite the bug, the layout in Global, bbPress and/or BuddyPress? DOES CHANGE to 1 column.

Thanks.

Mercime

Hi Mercime. A DevPress? member reported the layout_1c issue several days ago. We've since released a developer fix, but waiting to get everything updated to release an official update. Thank you for the thorough review. DevPress? needs feedback like yours for everything theme!

@chip

• License statement is fixed
• H2 tags do not clear floats on purpose
• Header search form only shows after you've assigned a menu for the Header Primary or Header Secondary menu location and after you've checked it at the theme settings page. I've triple checked this.
• Post Format Test: Linkded Image - I'm not sure what post format this should be. If this is supposed to be the Link post format then there's mistake in the theme unit test xml because the link post format is not assigned. Otherwise, the theme would display this properly.

@mercime

• Uneven alignment for lists is fixed
• BP Activity Favorite button is fixed
• The theme does not replace the Recent Posts widget with Recent Networkwide Post widget. All custom widgets can be found in library > classes

For everything else, I have to wait for Justin Tadlock to update the new and unreleased Hybrid Core version because that's what Fanwood is using.

http://themes.trac.wordpress.org/ticket/7665