WordPress.org

Make WordPress Themes

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#8597 closed theme (live)

THEME: P2 - 1.4.1

Reported by: automattic Owned by: kobenland
Priority: Keywords: theme-p2
Cc: themes@…

Description

P2 - 1.4.1

A group blog theme for short update messages, inspired by Twitter. Featuring: Hassle-free posting from the front page. Perfect for group blogging, or as a liveblog theme. Dynamic page updates. Threaded comment display on the front page. In-line editing for posts and comments. Live tag suggestion based on previously used tags. A show/hide feature for comments, to keep things tidy. Real-time notifications when a new comment or update is posted. Super-handy keyboard shortcuts. Helvetica Neue for you modern font lovers.

Theme URL - http://p2theme.com/
Author URL - http://automattic.com/

SVN - http://themes.svn.wordpress.org/p2/1.4.1
ZIP - http://wordpress.org/extend/themes/download/p2.1.4.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/p2/1.4.0&new_path=/p2/1.4.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-p2&order=id

http://themes.svn.wordpress.org/p2/1.4.1/screenshot.png

Change History (4)

comment:1 kobenland11 months ago

  • Owner set to kobenland
  • Status changed from new to accepted

comment:2 kobenland11 months ago

  • Resolution set to approved
  • Status changed from accepted to closed

Please address in next revision:

  • Themes are REQUIRED to state the copyright and license information for any bundled resources not covered by the Theme's license statement. --> spin.js (MIT)
  • Themes are REQUIRED to save options in a single array --> 'p2_background_image'


Review Summary

  • Previous version of Theme APPROVED
  • No previous-ticket required issues
  • Diff-review only
  • Ticket being resolved as APPROVED

Thanks,
Konstantin

comment:3 follow-up: automattic11 months ago

Hi Kobenland,

Thanks for pushing the update through :)

To follow up on the points that you cited The p2_background_image will be removed in P2 1.5 in place of core background features.

In regards to spin.js, it states directly in the file that it is licensed under the MIT. On line 4 you will find the following text:

/**
 * Copyright (c) 2011 Felix Gnass [fgnass at neteye dot de]
 * Licensed under the MIT license
 */

I thought that this would be enough to satisfy the requirement. If not, please let me know where else you would like to see this info.

Thanks for all your hard work!

comment:4 in reply to: ↑ 3 kobenland11 months ago

Replying to automattic:

In regards to spin.js, it states directly in the file that it is licensed under the MIT.
I thought that this would be enough to satisfy the requirement. If not, please let me know where else you would like to see this info.

Hm, I never actually thought about it this way. Guidelines recommend to (also) state this information in the Theme's README documentation. But you're right, this should be good enough.


Thanks for all your hard work!

Welcome! :)

Konstantin

Note: See TracTickets for help on using tickets.