THEME: WP UnFramework - 1.2.3

[c3mdigital]

WP UnFramework? - 1.2.3

Object orientated WordPress? Starter theme

Theme URL - ​https://github.com/c3mdigital/WP-UnFramework
Author URL - ​http://c3mdigital.com

SVN - ​http://themes.svn.wordpress.org/wp-unframework/1.2.3
ZIP - ​http://wordpress.org/extend/themes/download/wp-unframework.1.2.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/wp-unframework/1.2.2&new_path=/wp-unframework/1.2.3

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-wp-unframework&order=id

Issues from Previous Review

• NOT-FIXED: Floated elements must be properly cleared. See clearing-floats.jpg
• FIXED: Translation function added for identified text. However see below for more text that you have missed.

Theme Unit Tests

Index / Archive Views

• REQUIRED: The "Continue" link should go to the single post at "More" tag location.
• REQUIRED: Images with center-alignment (with and without captions) are not displayed in the center. See center-image.jpg and center-image-caption.jpg

Single Post View

• REQUIRED: Wide images should be re-sized as specified. See wide-images-resized.jpg

Navigation Menu

• REQUIRED: Check the styling of child links in the Navigation Menu. Long text is not contained within the box. See child-links.jpg. If this cannot be fixed, please note this in the readme.txt

Functionality

• REQUIRED: You have only included wp_nav_menu() for the primary menu. The "Footer Navigation Menu" has not been included. I can set a menu in Appearance >> Menu but I cannot see it on the site.

• REQUIRED: I can set content for the "sidebar" widget but I can't see it displayed anywhere on the site. In what instance can this sidebar be seen?

Code Quality

• REQUIRED: Make sure that text have the appropriate translation function:

Line 27, 28, Line 39, comments.php
Line 15, loop-footer.php
Line 19, loop-header.php

• REQUIRED: Additional scripts should not be hard-coded in the header template. The most appropriate way to handle the following is to place it in a function that hooks into wp_head.

  <!--[if lt IE 9]>
  <script src="<?php echo THEME_JS_URI; ?>html5shiv.js" type="text/javascript"></script>
  <![endif]-->
  

Recommendation: NOT-APPROVED

Hi garinungkadol,

Thank you for taking the time to do this review and for being so thorough! I have an updated version I can upload tomorrow. Can you keep this open till then? Thanks again.

Replying to c3mdigital:

Thank you for taking the time to do this review and for being so thorough! I have an updated version I can upload tomorrow. Can you keep this open till then? Thanks again.

Sure. Just post the link to the new ticket here and I'll continue the review there.

It's been 10 days since your last comment so I'm going to close this ticket.

When you've re-submitted your theme, leave the link here so I will check the changes and if everything is okay approve your theme.

Thanks
~ Vicky