THEME: Nusantara - 0.0.9

[amdhas]

Nusantara - 0.0.9

Nusantara Theme is designed for use by all wordpress user with drag and drop element, whether newbie or a professional who wants the ease of customization without the need for coding expertise. Nusantara Theme an elegant design flexibility of it's use and attractive. You can be free to be creative with 6 different responsive design homepage, custom post types, portfolio template style, color, header, font, CSS3 text-shadow, CSS3 box-shadow, rounded corner, template style every single post, page templates, unlimited slider effect, unlimited testimonial region, twitter widgets, image rotator, and much more. You can be free to customize the layout without having to open the theme file, reset button is also available if you want to go back to the default layout. Nusantara theme is perfect for all wordpress user and theme developer who wants create premium theme from the scratch.

Theme URL -
Author URL - ​http://amdhas.tk

SVN - ​http://themes.svn.wordpress.org/nusantara/0.0.9
ZIP - ​http://wordpress.org/extend/themes/download/nusantara.0.0.9.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/nusantara/0.0.8&new_path=/nusantara/0.0.9

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-nusantara&order=id

[amdhas]

Previous ticket:
http://themes.trac.wordpress.org/ticket/9417

[emiluzelac]

@Frank Klein please let me know if you can complete the review?

Thanks!

[Frank Klein]

Hey Emil,

I'm working on the review right now, I'm still looking at all the options (there are quite a lot ;)), I'll have it finished for this Friday.

By the way, I'm reviewing the most recent version of the theme 0.1.7 (http://themes.trac.wordpress.org/ticket/9543), I hope that's OK with you.

Thanks for your patience,
Fränk

[emiluzelac]

Thanks Fränk, I appreciate that.

[Frank Klein]

Nusantra Review

Policy Requirements

License

• Theme License and bundled resources (fonts, icons) are correct.
• Copyright is required to be explicitly declared in your style.css (cf. ​http://codex.wordpress.org/Theme_Review#Licensing in Copyright)
• Static homepage template uses WordPress? logo, which is not permitted.

Credit Links

• Author URI points to personal website, which after using Google Translate, doesn’t feature any non appropriate content.
• Upon activation, the footer features a credit link pointing to the author’s website as well as two additional icons link to his website and twitter account. These are not acceptable according to the guidelines: ​http://codex.wordpress.org/Theme_Review#Credit_Links To resolve this the author can simply remove the presets from the corresponding option.

Screenshot

The screenshot does not accurately represent the design of the final page.

Theme Check

Code Quality

• Please provide basic indentation, code is very hard to read.
• In functions.php, html5.js is enqueued for all versions of IE (should be for versions lower than IE9)
• Inputs are not systematically escaped

Template Files

There is no documentation on the specificities of Nusantra provided with the theme.

The Unit Tests

• Theme Check: Passed.
• No deprecated calls logged.
• HTML is valid
• CSS is nearly valid, with very few exceptions

Problems with theme templates

After the activation of the theme, with my front page set to display latest posts, the theme presents the following issues :

• The homepage displays a static page with placeholder content (cf. home-batavia.php).
• This page is entirely static, there is no loop
• The template file called by WordPress? is index.php, which presents a simple include of the merauke.php file. In this file, the homepage template is included based on the theme options.
• It’s not possible to have a blog using the reading settings, as index.php is the static page and there is no home.php

This is clearly problematic, the theme should provide an index.php that can serve as a fallback. For the custom blog page, a home.php should be used, the various homepages should be implemented using page templates.

Theme Options

The theme has A LOT of options, however using the options panel is very confusing, because there is no readme.txt, and because the provided instructions on the screens are not clear.

The theme options framework works, but it’s pretty sluggish, which may be due to the number of options available.

The biggest problem is that text can be injected into templates from multiple option screens. This text isn’t escaped, Javascript and HTML code can be freely used. You even can add sliders, ads images, etc... and all this is stored in the options table in the database.

I think this theme clearly crosses the line when it comes to using theme options. Content should not be controlled using options.

Widgets

The theme features 17 widgets areas, however it’s difficult to know where widgets will appear, since the names that are used, like “two-columns-region2” are not very clear.

The Theme features an Ad Rotator widget, however the widget is supposed to show content that are stored in the options table, so its use is not very clear (you have to inspect the code to find out how it works).

Conclusion

The theme itself is solid, however the problems are the options. There are way too many, they don't work correctly in some cases and they duplicate core functionality.

I recommend the theme to not be approved in the actual state.