Opened 8 months ago

Closed 7 months ago

#9502 closed theme (not-approved)

THEME: Gallery - Portfolio - 1.1

Reported by: robisklp Owned by: garinungkadol
Priority: major Keywords: theme-gallery-portfolio
Cc: robisklp@…

Attachments (2)

site-title.jpg (36.5 KB) - added by garinungkadol 7 months ago.
footer-widgets.jpg (212.4 KB) - added by garinungkadol 7 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 months ago by garinungkadol

  • Owner set to garinungkadol
  • Status changed from new to assigned

Changed 7 months ago by garinungkadol

Changed 7 months ago by garinungkadol

comment:2 Changed 7 months ago by garinungkadol

  • Resolution set to not-approved
  • Status changed from assigned to closed

General Information

  • REQUIRED: Check the credit link in the footer, you are linking to the current blog, not your Theme URI or Author URI.
  • REQUIRED: Check the spelling of "WordPress?" on the Theme URI. Note the capital "W" and "P".
  • REQUIRED: Themes are required to declare copyright and license information as specified by the applicable license in style.css, e.g.:
      Twenty Eleven WordPress Theme, Copyright 2011 WordPress.org
      Twenty Eleven is distributed under the terms of the GNU GPL
    
  • What is the purpose of test.php?

Debogger Information

On site after theme is first activated
-- Debug: Undefined variable: class on line 24 of C:\xampp\htdocs\wpthemes\wp-content\themes\gallery-portfolio\header.php

Theme Unit Test

General

  • REQUIRED: The Site title and description must be displayed by default. See site-title.jpg

Pages

  • REQUIRED: Pages with comments disabled must not show any kind of "Comments are Closed" message.

Widgets

  • REQUIRED: Check the styling of the footer widgets. The text is not legible. See footer-widgets.jpg.

Functionality

  • REQUIRED: Check your implementation of Navigation Menus. The menu I have selected is not being displayed. It is a different menu.
  • REQUIRED: Check your implementation of "Theme Options". When I click on the link, I remain on the page I'm currently on.
  • I'm finding the image hover to be buggy. After I hover over the thumbnail, the larger version continues to be displayed even when I move my mouse from the thumbnail.

Code Quality

  • REQUIRED: Scripts should not be enqueued within template files. The 'comment-reply' script belongs in a callback function attached to the appropriate hook, either wp_enqueue_scripts or comment_before_form.
  • REQUIRED: Only the theme's style.css make be hard-coded in document head. All other stylesheets must be properly enqueued or hard-coded in a callback function attached to an appropriate hook, e.g. wp_enqueue_scripts or wp_head.
  • REQUIRED: For enqueued scripts, the handle names shouldt be prefixed.
  • REQUIRED: Backward compatibility is intended for new functionality introduced 2 versions prior to WP3.4. There is no need to perform function_exists() checks for dynamic_sidebar and register_sidebar
  • REQUIRED: By default themes are recommended not to implement custom favicon functionality. If implemented, favicon functionality is required to be opt-in, and disabled by default. Such functionality is required to support user-defined favicon images.
  • REQUIRED: <?php wp_head(); ?> must be placed directly before </head>
  • REQUIRED: Searchform must be displayed using get_search_form().
  • REQUIRED: Themes are required to use core-bundled scripts, if using such scripts
    • Make use of the jQuery library that comes with WordPress?.
  • REQUIRED: As you are not supporting translation, remove translation functions in functions.php, Line 39 and 92.
  • REQUIRED: Themes are required to validate and sanitize all untrusted data before entering data into the database, and to escape all untrusted data before being output in the Settings form fields or in the Theme template files

Review Summary

  • This is a new theme
  • Performed a theme check, code quality review and partial theme unit test.
  • Resolving ticket as not-approved due to the above issues.

Before re-submitting your theme, check it against the Theme Review guidelines and Theme Unit Test. The following tools will be of use during this process:

If you have any questions about this review, feel free to ask here.
~ Vicky

Note: See TracTickets for help on using tickets.