THEME: Playground - 1.0

[Jarlund]

Playground - 1.0

A theme by Mikkel Jarlund, based on the s_theme.

Theme URL - ​https://twitter.com/MikkelJarlund
Author URL -

SVN - ​http://themes.svn.wordpress.org/playground/1.0
ZIP - ​http://wordpress.org/extend/themes/download/playground.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-playground

[garinungkadol]

General Information

• REQUIRED: A Twitter account is not appropriate as a Theme URI.
  • A Theme URI should contain information specific to the theme and must not be a mere demo page.

• REQUIRED: Footer credit link must use either the Theme URI or Author URI.

• REQUIRED: Document code block contains references to Jarlund Project. Replace this with the theme's name.

   * Jarlund Project Theme Options
   *
   * @package Jarlund Project
   * @since Jarlund Project 1.0
  

• REQUIRED: Update the readme.txt - it contains details for the 'underscores' theme not your theme

• Remove unnecessary files like the theme options since your theme doesn't support it.

Debug Errors

On Site
-- Debug: Undefined variable: do_not_duplicate on line 37 of C:\xampp\htdocs\wpthemes\wp-content\themes\playground\index.php

Single Post View With Comments
Other warnings: 2
-- Debug: Undefined variable: args on line 74 of C:\xampp\htdocs\wpthemes\wp-content\themes\playground\comments.php
-- Debug: Undefined variable: post_id on line 74 of C:\xampp\htdocs\wpthemes\wp-content\themes\playground\comments.php

Theme Unit Tests

Single Post View

• REQUIRED: h1-h6 elements are styled (as appropriate). I notice that h1-h6 does not have a difference in styling when used in post content. Is this intentional?

• REQUIRED: Wide images that are resized in the content editor must be displayed in the resized dimensions. See wide-image-resized-in-editor.jpg

Functionality

• REQUIRED: You must use wp_nav_menu() to display the menu defined in Appearance >> Menu. wp_page_menu() should only be used as a callback for default display.

• REQUIRED: Please describe how the Featured posts will work in the readme.txt. At the moment, all that is showing is a blank white space. I suggest you do some kind of check to see if the "Featured" category exists before including the template.

Code Quality

• REQUIRED: Check all instances of do_action() and apply_filters() to make sure that hook names have an appropriate prefix.

• REQUIRED: As you are supporting translation, make sure that all text is localized. See featured.php, index.php

• REQUIRED: Themes are required to use function parameters, filters, and action hooks where appropriate in order to modify content, rather than hard-coding. Modify the contents of the <title> tag using the wp_title filter
  • References:
  • ​http://wordpress.stackexchange.com/questions/32622/when-calling-wp-title-do-you-have-to-create-some-kind-of-title-php-file
  • ​http://wikiduh.com/1102/using-the-wp_title-filter-in-wordpress

• REQUIRED: Scripts should not be hard-coded in the document head.
  • Place the HTML5 shiv script in a callback function that hooks into wp_head.

• REQUIRED: use get_template_part() or locate_template() to include template files instead of using TEMPLATEPATH.

REVIEW SUMMARY

• This is a new theme.
• Performed a complete review.
• Resolving ticket as not-approved due to the above issues.

Before re-submitting your theme, check it against the ​Theme Review guidelines and ​Theme Unit Test. The following tools will be of use during this process:

• Theme Check Plugin: ​http://wordpress.org/extend/plugins/theme-check/
• Log Deprecated Notices: ​http://wordpress.org/extend/plugins/log-deprecated-notices/
• Debogger: ​http://wordpress.org/extend/plugins/debogger/
• Debug Bar: ​http://wordpress.org/extend/plugins/debug-bar/

If you have any questions about this review, feel free to ask here.