Opened 8 months ago

Closed 7 months ago

#9525 closed theme (not-approved)

THEME: Playground - 1.0

Reported by: Jarlund Owned by: garinungkadol
Priority: major Keywords: theme-playground
Cc: mikkel.jarlund@…

Description

Attachments (1)

wide-image-resized-in-editor.jpg (51.5 KB) - added by garinungkadol 7 months ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 7 months ago by garinungkadol

  • Owner set to garinungkadol
  • Status changed from new to assigned

Changed 7 months ago by garinungkadol

comment:2 Changed 7 months ago by garinungkadol

  • Resolution set to not-approved
  • Status changed from assigned to closed

General Information

  • REQUIRED: A Twitter account is not appropriate as a Theme URI.
    • A Theme URI should contain information specific to the theme and must not be a mere demo page.


  • REQUIRED: Footer credit link must use either the Theme URI or Author URI.
  • REQUIRED: Document code block contains references to Jarlund Project. Replace this with the theme's name.
     * Jarlund Project Theme Options
     *
     * @package Jarlund Project
     * @since Jarlund Project 1.0
    
  • REQUIRED: Update the readme.txt - it contains details for the 'underscores' theme not your theme
  • Remove unnecessary files like the theme options since your theme doesn't support it.

Debug Errors

On Site
-- Debug: Undefined variable: do_not_duplicate on line 37 of C:\xampp\htdocs\wpthemes\wp-content\themes\playground\index.php

Single Post View With Comments
Other warnings: 2
-- Debug: Undefined variable: args on line 74 of C:\xampp\htdocs\wpthemes\wp-content\themes\playground\comments.php
-- Debug: Undefined variable: post_id on line 74 of C:\xampp\htdocs\wpthemes\wp-content\themes\playground\comments.php

Theme Unit Tests

Single Post View

  • REQUIRED: h1-h6 elements are styled (as appropriate). I notice that h1-h6 does not have a difference in styling when used in post content. Is this intentional?

Functionality

  • REQUIRED: You must use wp_nav_menu() to display the menu defined in Appearance >> Menu. wp_page_menu() should only be used as a callback for default display.
  • REQUIRED: Please describe how the Featured posts will work in the readme.txt. At the moment, all that is showing is a blank white space. I suggest you do some kind of check to see if the "Featured" category exists before including the template.

Code Quality

  • REQUIRED: Check all instances of do_action() and apply_filters() to make sure that hook names have an appropriate prefix.
  • REQUIRED: As you are supporting translation, make sure that all text is localized. See featured.php, index.php
  • REQUIRED: Scripts should not be hard-coded in the document head.
    • Place the HTML5 shiv script in a callback function that hooks into wp_head.
  • REQUIRED: use get_template_part() or locate_template() to include template files instead of using TEMPLATEPATH.

REVIEW SUMMARY

  • This is a new theme.
  • Performed a complete review.
  • Resolving ticket as not-approved due to the above issues.

Before re-submitting your theme, check it against the Theme Review guidelines and Theme Unit Test. The following tools will be of use during this process:

If you have any questions about this review, feel free to ask here.

Note: See TracTickets for help on using tickets.