THEME: OmaGue - 0.2

[dhenycahyoe]

OmaGue? - 0.2

HTML 5 Minimalist and Responsive WordPress? themes. Clean blogging theme, good for you who wants focused on the content. It supports 9 widget areas.

Theme URL -
Author URL - ​http://omague.com/

SVN - ​http://themes.svn.wordpress.org/omague/0.2
ZIP - ​http://wordpress.org/extend/themes/download/omague.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/omague/0.1&new_path=/omague/0.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-omague&order=id

previous ticket:
http://themes.trac.wordpress.org/ticket/9505

Changelog
see readme.txt

0.2

• fix the bug on commnets.php
• fix stylehome.css and stye.css
• improve the options panel
• improve the structure of language
• Add template maker links and special thank's list on theme options page

Many Thank's
dheny

General Information

• REQUIRED: If your theme is based of another theme (considered a derivative work), you must retain/declare the copyright information of the original work

• REQUIRED: Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.
  • The Droid Sans font is licensed under Apache License, Version 2.0 which is only compatible with GPL 3. If you wish to keep the Droid Sans font then you must change the license in style.css to GNU General Public License v3.0

• Check your theme options. The title should be "Social Media" not "Sosial Media"

Debug Errors

On site after theme activation
-- Debug: Use of undefined constant OmaGue? - assumed 'OmaGue?' on line 4 of C:\xampp\htdocs\wpthemes\wp-content\themes\omague\footer.php

On theme options page
-- Debug: Undefined index: action on line 48 of C:\xampp\htdocs\wpthemes\wp-content\themes\omague\includes\options.php
-- Debug: Undefined index: action on line 55 of C:\xampp\htdocs\wpthemes\wp-content\themes\omague\includes\options.php
-- Debug: Undefined index: saved on line 75 of C:\xampp\htdocs\wpthemes\wp-content\themes\omague\includes\options.php
-- Debug: Undefined index: reset on line 76 of C:\xampp\htdocs\wpthemes\wp-content\themes\omague\includes\options.php

Theme Unit Tests

General

• I'm finding some of the font colors too dark. For example, the site title and the tag listing in the sidebar. The same goes with the post navigation.

• I think a bit more line-height would help improve readability. See readability.jpg

Blog Index View

• REQUIRED: Posts with no title must still include the permalink to the single post view.

Single Post View

• REQUIRED: Check the styling of unordered and ordered lists when used in comments. See comments-lists.jpg

Menu

• Is it your intention to display all links (including child links) by default?

Functionality

• REQUIRED: Please check your code.
  • On the "Protected: Test with secret password" test, after entering the password all that shows up is a blank white page.
  • I get the same problem after saving theme options

• REQUIRED: I cannot see the social media links that I have set.

• REQUIRED: The background image that I set is not appearing on the site.

Code Quality

• REQUIRED: Do not remove core functionality (functions.php - Line 57 - 66) without user's permission.

• REQUIRED: Page view functionality is plugin territory. If you wish to include it, the user must opt in to enable this functionality.

• REQUIRED: Please note that while translation is optional, if implemented it must be fully supported.
  • If you are supporting translation then you must:
    • Load the theme's textdomain
    • Make sure that all text are localized. See
  single.php, 404.php, archive.php, footer.php, page.php, search.php, functions.php, includes\options.php
  • If you don't want to support translation then remove all translation functions for template files.

• REQUIRED: Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.). See includes\options.php for global variables that do not have a prefix.

• REQUIRED: Themes are required to use the edit_theme_options capability for add_theme_page(), rather than rely on a role (e.g. "administrator"), or a different capability (e.g. "edit_themes", "manage_options") for the capability to add the settings page.

• REQUIRED: Themes are required to save options in a single array, rather than create multiple options for its settings page

• REQUIRED: Since you are not implementing Settings API you must provide explicit Settings-page nonce checking. See ​WordPress Nonces

• REQUIRED: Themes are required to validate and sanitize all untrusted data before entering data into the database, and to escape all untrusted data before being output in the Settings form fields or in the Theme template files (see: Data Validation)

• REQUIRED: Themes are required to use esc_attr() for text inputs and esc_html() (or esc_textarea() in WP 3.1) for textareas.

• REQUIRED: For checkboxes and select options, Themes are required to use the checked() and selected() functions for outputting checked="checked" and selected="selected", respectively.

• REQUIRED: Styles should not be hard-coded in template files.
  • For 404.php, place the <style> code in a callback function that hooks into wp_head. You can use the conditional tag ​is_404() to control where the CSS will appear.

Review Summary

• This is a new theme.
• Performed a complete review.
• Resolving ticket as not-approved due to the above issues.

Deny, before re-submitting your theme, check it against the ​Theme Review guidelines and ​Theme Unit Test. The following tools will be of use during this process:

• Theme Check Plugin: ​http://wordpress.org/extend/plugins/theme-check/
• Log Deprecated Notices: ​http://wordpress.org/extend/plugins/log-deprecated-notices/
• Debogger: ​http://wordpress.org/extend/plugins/debogger/
• Debug Bar: ​http://wordpress.org/extend/plugins/debug-bar/

If you have any questions about this review, feel free to ask here.
~ Vicky

Replying to garinungkadol:

General Information

• REQUIRED: If your theme is based of another theme (considered a derivative work), you must retain/declare the copyright information of the original work

• REQUIRED: Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.
  • The Droid Sans font is licensed under Apache License, Version 2.0 which is only compatible with GPL 3. If you wish to keep the Droid Sans font then you must change the license in style.css to GNU General Public License v3.0

Hy Vicky
Thank you for your review,

if I want to keep using the Droid font, if only to change the style.css lisense GNU General Public License v3.0

regards

"dheny"

Replying to dhenycahyoe:

if I want to keep using the Droid font, if only to change the style.css lisense GNU General Public License v3.0

Dheny,
That is correct. The Apache license is compatible with GPL 3.

Updated ticket:
http://themes.trac.wordpress.org/ticket/9850

Thank's
dheny