THEME: ShadowBlue - 0.9.5

[interjc]

ShadowBlue? - 0.9.5

两栏+底部Footbar主题(two-columns and three-columns in the footbar), 有意见或建议或关注后续版本请至 <a href="​http://interjc.net/dev/shadowblue">开发页面(develope page)</a> 或者(or) <a href="​https://github.com/interjc/ShadowBluee">查看源码(view the source code)</a>. Follow me via Twitter: @<a href="​http://twitter.com/interjc">interjc</a> or Weibo @<a href="​http://weibo.com/interjc">4893119</a>

Theme URL - ​https://github.com/interjc/ShadowBlue
Author URL - ​http://interjc.net/

SVN - ​http://themes.svn.wordpress.org/shadowblue/0.9.5
ZIP - ​http://wordpress.org/extend/themes/download/shadowblue.0.9.5.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/shadowblue/0.9.4&new_path=/shadowblue/0.9.5

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-shadowblue&order=id

General Information

• REQUIRED: "Description" in style.css must be include English text.
• REQUIRED: You are allowed one credit link in the footer. This must either be the Theme URI or Author URI.
• REQUIRED: Include the copyright/license information of bundled resources such as scripts and images. Make sure that the license is GPL-compatible.

Debug Errors ==

On Main Site
-- Debug: Undefined variable: blogOption on line 2 of C:\xampp\htdocs\wpthemes\wp-content\themes\shadowblue\nav.php
-- Debug: Undefined variable: blogOption on line 1 of C:\xampp\htdocs\wpthemes\wp-content\themes\shadowblue\footbar.php

Theme Unit Test

Blog Index View

• REQUIRED: Check the styling of your navigation menu. When the Admin Bar is enabled, part of the content is hidden. See menu-admin-bar.jpg

• REQUIRED: Check the $content_width. Images and videos should re-size to fit this width. See content-width-1.jpg

• REQUIRED: Please check this: part of the category name is cut-off. See blog-category.jpg. If this cannot be fixed, please note this in the readme.txt

• REQUIRED: Posts with no title must still contain the permalink to the single post view.

Single Post View

• REQUIRED: Ordered and unordered lists when used in posts and comments must be appropriately styled. See html-lists.jpg.

• REQUIRED: Images with center alignment must be styled appropriately. See center-align-image.jpg

Search

• REQUIRED: The 'No Search Results' page must show some content.

Functionality

• REQUIRED: For the post license, you must allow the user to choose what license they wish to place their post under.
  • This feature should be opt-in and disabled by default.

• REQUIRED: Check your implementation of Custom Headers. This is what I see on the back-end. See custom-header-image.jpg.
  • Even if I remove the image from the back-end, it is still displayed on the site.
  • If the option "Show header text with your image" is enabled then you must show the site title and/or site description.

• REQUIRED: Check your implementation of the 'comment-reply' script.

• REQUIRED: Check your implementation of Navigation Menus. The menus that I set in the back-end do not appear on the site.

Code Quality

• REQUIRED: Themes are required to use core-bundled scripts, if using such scripts.
  • You must use jQuery that comes with WordPress?. Do not include different versions of jQuery with your theme.

• REQUIRED: Backward compatibility is recommended for new functionality added two versions prior to the current WordPress? version.
  • There is no need for function_exists() checks for older core functionality like dynamic_sidebar().

• REQUIRED: Check comments.php. You are lacking an opening `<?php in line 13

• REQUIRED: wp_footer() must be placed directly before </body>.

• REQUIRED: Scripts/styles should not be hard-coded in the header or footer templates.
  • Either enqueue scripts/styles inside a callback function hooked to the appropriate action hook or
  • Place your script/style in a callback function that hooks into wp_head for the header or wp_footer for the footer.

• REQUIRED: If supporting translation, all public-facing text must be localized.
  • See header.php

• REQUIRED: Themes are required to use function parameters, filters, and action hooks where appropriate in order to modify content, rather than hard-coding. Modify the contents of the <title> tag using the wp_title filter
  • References:
  • ​http://wordpress.stackexchange.com/questions/32622/when-calling-wp-title-do-you-have-to-create-some-kind-of-title-php-file
  • ​http://wikiduh.com/1102/using-the-wp_title-filter-in-wordpress

• REQUIRED: Use ​get_stylesheet_uri() to reference the theme's style.css instead of bloginfo('stylesheet_url').

REVIEW SUMMARY

• This is a new theme
• Performed a complete review
• Resolving ticket as not-approved due to above issues.

Before re-submitting your theme, please check it against the ​Theme Review guidelines and ​Theme Unit Tests.

If you have questions about this review, feel free to comment here.

~ Vicky