Opened 8 months ago

Closed 6 months ago

#9644 closed theme (closed-newer-version-uploaded)

THEME: SemPress - 1.1.0

Reported by: pfefferle Owned by: Cryout Creations
Priority: major Keywords: theme-sempress
Cc: pfefferle@…

Description

SemPress? - 1.1.0

A highly semantic, HTML5 template, responsive and seo optimized. SemPress? supports most of the new HTML5 tags, the new HTML5 input-types, microformats, microformats v2 and microdata (Schema.org).

Theme URL - https://github.com/pfefferle/SemPress
Author URL - http://notizblog.org/

SVN - http://themes.svn.wordpress.org/sempress/1.1.0
ZIP - http://wordpress.org/extend/themes/download/sempress.1.1.0.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/sempress/1.0.0&new_path=/sempress/1.1.0

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-sempress&order=id

http://themes.svn.wordpress.org/sempress/1.1.0/screenshot.png

Change History (5)

comment:1 Changed 7 months ago by Cryout Creations

  • Owner set to Cryout Creations
  • Status changed from new to assigned

comment:2 Changed 7 months ago by Cryout Creations

Theme Review: SemPress?
=> Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
=> Themes should be reviewed using the test data from the Theme Checklists


=> In style.css please also add version number to License ( the version in licence.txt)
=> The footer has way too many links. Have a quick read here. http://codex.wordpress.org/Theme_Review#Credit_Links

Mainly :

  • Themes may optionally include a public-facing credit link in the Theme footer.
  • If used, Themes are required to include no more than one such footer credit link.
  • Credit link, if used, is required to use either Theme URI or Author URI.

All the other credits you want to (and should) give must be present in the readme.txt file. All libraries, fonts and images that you use should be under the GPL and should be credited in the readme file.


Theme Check PASS


Code Quality

=> No scripts or script file links are hard-coded into the document head. (These must be enqueued and hooked in appropriately.)

I mean the HTML5 script.

=> No unnecessary meta tags (WordPress? generator tag, SEO meta tags, copyright meta tags, etc.) are hard-coded into the document head.

The meta description and keywords should be disabled by default and enabled only if the user chooses to enable them.


Theme Unit Tests

Debogger PASS
Deprecated Calls PASS
=> Please test the menu with more items so they go over one line. I really suggest using the Theme unit test Theme Checklists to check your theme


I'll keep the ticket open for a few days so you can fix the required issues and resubmit the theme.


Overall: not-accepted

  • Items marked (=>) must be addressed.
  • Other items noted should be addressed and corrected as needed.
  • Additional review may be required once the above issues are resolved.

comment:3 Changed 7 months ago by pfefferle

Thanks for the review! I have uploaded a new version here: http://themes.trac.wordpress.org/ticket/9856

Changes:

  • only one author link in the footer
  • moved the html5 script to the functions.php
  • removed the SEO meta-tags
  • updated the license and added the version
  • added a "credits" part to the readme.txt

comment:4 Changed 6 months ago by pfefferle

Uploaded a new version with some small CSS changes here: http://themes.trac.wordpress.org/ticket/10056

comment:5 Changed 6 months ago by Cryout Creations

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.