THEME: Inkblot - 4

[mgsisk]

Inkblot - 4

Elegant, fully responsive, highly customizable <a href="​http://webcomic.nu">Webcomic</a>-ready theme named in honor of Rorschach from the Watchmen graphic novel.

Theme URL - github.com/mgsisk/inkblot
Author URL - ​http://mgsisk.com

SVN - ​http://themes.svn.wordpress.org/inkblot/4
ZIP - ​http://wordpress.org/extend/themes/download/inkblot.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/inkblot/2.0.0&new_path=/inkblot/4

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-inkblot&order=id

[trkr]

Results

[trkr]

Check attached file please.

[mgsisk]

Thanks for the feedback! Just a few questions I hope you can clear up before I submit an update:

1. "Theme doesnt support IE7 and IE8" - Is IE7 and IE8 support a requirement for listing in the directory? I can't find any information related to specific browser support, nor am I able to test in these browsers.
2. "Theme does not support playing audio files." - I noticed the audio file linked to in the Theme Unit Test XML seems to be missing; I swapped it with the audio file used on wpthemetestdata.wordpress.com, which appears to work. The theme review guidelines only mention enclosure support and I'm assuming pointing to an audio file that exists would correct any enclosure issues, but is there anything else themes are required to provide for audio post formats (an inline player, for example)?
3. "The post which has no title doesnt have a link to the sinle-page post view." - The date in the post footer links to the single-page post view; is this insufficient?

Thanks again!

[emiluzelac]

<-- IE8 is not required, good thing to do, but it should not reflect the review :)

[trkr]

Hi,

Sorry about confusion. I thought qualified user(s) will check my review before it is become public so i put all errors and notices to the result file.

Anyway, IE7 and IE8 supports are not required but i suggest you to add supported browsers to readme file. (As a wordpress user and developer i prefer html5, css3 and IE8 supported themes)

Inline audio player not required. Custom field enclosure is enough.

If you check "2008/05/this-post-has-no-body/" post, "Previous Post" link gives 404 error. Same thing happens from index. If you click no title post's date link you'll get 404 error.

Turker.

[mgsisk]

Thanks emiluzela! And thanks for the clarifications Turker; I appreciate the thoroughness. I just wanted to make sure there wasn't something specific I'd overlooked in the guidelines; adding browser-compatibility to the read me is a great idea.

The only one I'm still unsure on is the last one about the no title post… I can't seem to duplicate the 404's on my own dev box. The index links, date links, and the previous link from "This post has no body" all correctly load the no-title post.

[emiluzelac]

@trkr would you please clarify the questions about 404 for @mgsisk?

Thanks!

[trkr]

Hi,

I created 2nd no title post and its links are all fine. I think something bugy in theme unit test data or something else. If required i can attach screenshots.

Turker.

[emiluzelac]

I'll close the ticket, please re-submit once the requirements are fixed :)

[mgsisk]

Thanks again trkr and emiluzelac!

[chipbennett]

Note: due to a limitation of the importer script, and the way WordPress? handles numeric-only titles an URL rewrites, you need to reset the permalink for the Post with no Title. Once you do that, the 404 issue should be resolved.