THEME: v11 - 1.1

[betzster]

v11 - 1.1

v11 is a responsive theme with a customizable background. There are built-in widgets to display your biography and links to your social networking profiles.

Theme URL - ​http://joshbetz.com/2012/08/v11/
Author URL - ​http://joshbetz.com/

SVN - ​http://themes.svn.wordpress.org/v11/1.1
ZIP - ​http://wordpress.org/extend/themes/download/v11.1.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/v11/1.0&new_path=/v11/1.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-v11&order=id

[sixhours]

Theme Check Plugin Results

WARNING: .gitignore Hidden Files or Folders found.
REQUIRED: Please remove any extraneous directories like .git or .svn from the ZIP file before uploading it.

Previous Issues: FIXED -- Thank you!

• -- Debug: Undefined offset: 1 on line 19 of C:\xampp\htdocs\wpthemes\wp-content\themes\v11\includes\bio-widget.php
• REQUIRED: Check how gallery images are displayed. See gallery-display.jpg
• REQUIRED: Posts with no title should still include the permalink to the single post view. If pretty permalinks are enabled, the shortlink display is visible. If pretty permalinks are not enabled, there is no shortlink
• REQUIRED: Theme must incorporate the "Category" taxonomy in some manner - either on the the blog index view, single page view or both. -- Categories still do not display in single or blog index views.
• REQUIRED: Check the styling of the <cite> tag when used in comments. See html-tags-comments.jpg vs html-tags-comments-expected.jpg
• Is this the intended display for navigation icons? See navigation.jpg
• REQUIRED: Please check the Icons Widget. I am unable to save the "Title".
• REQUIRED: wp_head() must always appear directly before </head>

Previous Issues: NOT FIXED

• RECOMMENDED: For the Icons Widget, a short note explaining that the user should include the full URL will be helpful. -- I agree this would be helpful, as would explaining what the Bio widget email address does. Some users may be hesitant to put in their email address without knowing what data this accesses.
• REQUIRED: You should include an un-minified version of your stylesheets for reference purposes. e.g. style-dev.css
• REQUIRED: As you are supporting translation, make sure all public-facing text is properly localized. See:

content-meta.php - Line 12 - sentence is not translatable
loop-base.php - Line 47 uses '_s' instead of the proper textdomain, 'v11'
archive.php - Line 18 uses '_s'
searchform.php - Line 4, value "Search" is not translatable

• REQUIRED: Scripts and styles should not be hard-coded in the document head. The only exception is the theme's style.css which may be hard-coded in the header template. All other scripts and styles must either be enqueued and hooked into wp_enqueue_scripts or placed in a function that hooks into wp_head - use the priority argument to control where in the document head the code will appear. See line 10 in header.php:

  <script>(function(H){H.className=H.className.replace(/\bno-js\b/,'js')})(document.documentElement)</script>
  

Visual

• RECOMMENDED: Calendar widget could use styling: ​http://www.evernote.com/shard/s213/sh/4e43c379-3201-4d19-8cf2-6f436ba373e9/9b19cd0ced74688adc1222acada53aeb
• RECOMMENDED: It would be nice if large images did not overflow the sidebar, and could be constrained using max-width: 100%/height: auto: ​http://www.evernote.com/shard/s213/sh/e7c3fa85-66a9-4f35-9777-b67ee9c10b00/b5209c37a50bd9408510c92bdc963c35
• RECOMMENDED: Nested list items in the sidebar widgets could use some styling attention: ​http://www.evernote.com/shard/s213/sh/9976f0c5-0fd6-4207-a0c0-0181501ba579/ddb83822f9f5c21fa79effbd9e27c2f6

Licensing

• REQUIRED: The font license for the IcoMoon? custom generated font set should be listed somewhere in readme.txt. For a list of GPL-compatible font licenses, see here: ​http://codex.wordpress.org/Theme_Review#GPL-Compatible_Font_Licenses

Recommendation

Thanks for your theme submission! Based on the above review, I'm marking this as Not Approved.

Please address all REQUIRED items and resubmit your theme. In an effort to keep the themes queue moving, I'll keep this ticket open for 2-3 days while you make these changes. Comment here with a link to the new ticket and I'll be happy to re-review in that time.

If you have questions, please let me know in ticket. Thanks again!

[betzster]

• The un-minified version of the styles are in the sass directory.
• There has been previous conversation on the theme reviewers' mailing list suggesting that one line scripts are acceptable.

I'll go ahead and make the other changes and submit within a couple days. Thanks!