Opened 7 months ago

Closed 6 months ago

#9700 closed theme (closed-newer-version-uploaded)

THEME: Foliage - 1.3

Reported by: voisula Owned by: sixhours
Priority: major Keywords: theme-foliage
Cc: voisula@…

Description

Foliage - 1.3

Foliage is really lightweight and simple theme. This theme is optimized by professionals for better search engine visibility, or SEO. Optimization will boost your ranks in search engines and give you more visitors.

Theme URL - ​http://www.themeplate.net/
Author URL -

SVN - ​http://themes.svn.wordpress.org/foliage/1.3
ZIP - ​http://wordpress.org/extend/themes/download/foliage.1.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/foliage/1.2&new_path=/foliage/1.3

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-foliage&order=id

http://themes.svn.wordpress.org/foliage/1.3/screenshot.png

Change History (4)

comment:1 Changed 6 months ago by sixhours

  • Owner set to sixhours
  • Status changed from new to assigned

comment:2 Changed 6 months ago by sixhours

Theme Check

PASSED

Previous Issues - FIXED - thank you!

  • I see images in the theme. Please also mention copyright/license of images ( or icons along with code) in readme.txt. Should be GPL compatible.
  • found hard-coded date in footer.php. Please use date() function instead.
  • Themes are recommended not to implement custom favicon functionality. If implemented, favicon functionality is required to be opt-in, and disabled by default.
  • Recommend: Please remove the comment reply script from header.php and add it to functions.php
  • Themes are required to have a correct XFN profile link in <head> tag
  • I found wp_head() 2 times in header.php. Please remove one of them
  • There is no post navigation in single posts. next_post_link/previous_post_link
  • I can't find the editor-style.css in your theme. Please remove add_editor_style(); from functions.php if you don't support this feature.
  • tables need css styling
  • Please fix the problem with center-align ​​http://d.pr/i/LeKh
  • Please fix the problem with right-align

Previous Issues - NOT FIXED

  • RECOMMENDED: add_custom_background found in the file functions.php. Deprecated since version 3.4. Use add_theme_support( 'custom-background', $args ) instead.
  • REQUIRED: Themes are required to validate and sanitize all untrusted data before entering data into the database, and to escape all untrusted data before being output in the Settings form fields or in the Theme template files. Replace home_url( '/' ) with esc_url( home_url( '/' ) ) in widget_sidebar_search and widget_footer_search
  • REQUIRED: The theme has a problem with long words in the site title overflowing into the menu area -- this should be contained either with overflow: hidden; or word-wrap: break-word;​​http://d.pr/i/B2Hf
  • REQUIRED: Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.) - see new_excerpt_more, widget_footer_search, widget_sidebar_search, theme_comment, etc.
  • REQUIRED: Themes must not provide backward compatibility for out-of-date WordPress?? versions, including using function_exists() conditional wrappers for current WordPress?? functions. see:

if ( function_exists('dynamic_sidebar') ) in sidebar.php

Code

  • REQUIRED: Sidebars should be registered in a function hooked to widgets_init using an action, like so: 
function register_sidebars() {
   //Register your sidebars here
}
add_action( 'widgets_init', 'register_sidebars' );
  • REQUIRED: Similarly, new widget registration should be hooked into widgets_init
  • REQUIRED: Comment reply script (and others) in functions.php should be added in a function hooked into wp_enqueue_scripts, like so: 
function my_scripts() {
   //Register your scripts here
}
add_action( 'wp_enqueue_scripts', 'my_scripts' );
  • RECOMMENDED: Functions such as add_custom_background(), add_theme_support( 'post-thumbnails' ), etc. should be added to a function and hooked into after_setup_theme, similar to the examples above.

Theme Unit Test

Recommendation

Thanks for submitting your theme! Foliage has several REQUIRED issues noted above that need to be addressed. Marking as Not Approved for now.

I'll keep this ticket open for 2-3 days -- if you can fix the required issues in that time, please resubmit your theme and comment here with a link to the new ticket and I'll be happy to re-review.

If you have any questions, please feel free to ask in-ticket.

Thanks again!

comment:3 Changed 6 months ago by voisula

Hi!

Here is link to the fixed theme ticket http://themes.trac.wordpress.org/ticket/10064.

About some of the issues:

REQUIRED: The theme has a problem with long words in the site title overflowing into the menu area
--> That should have been already done, see ​http://i.imgur.com/g1LDs.png

comment:4 Changed 6 months ago by sixhours

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.