Opened 8 months ago

Closed 7 months ago

Last modified 7 months ago

#9718 closed theme (not-approved)

THEME: Gringe - 1.0

Reported by: jathin Owned by: trkr
Priority: major Keywords: theme-gringe
Cc: jathinsdpi@…

Description

Gringe - 1.0

Gringe is primarily intended for personal blogs , travelogues etc. If you like to make a Personal Blog with lots of pics you can make use of Gringe for more info and support you can visit <a href="http://themegringe.wordpress.com">Gringe support site</a>.

Theme URL - http://wordpress.org/extend/themes/gringe
Author URL - http://themegringe.wordpress.com

SVN - http://themes.svn.wordpress.org/gringe/1.0
ZIP - http://wordpress.org/extend/themes/download/gringe.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-gringe

http://themes.svn.wordpress.org/gringe/1.0/screenshot.png

Change History (4)

comment:1 Changed 7 months ago by emiluzelac

  • Owner set to trkr
  • Status changed from new to assigned

comment:2 follow-up: Changed 7 months ago by trkr

Requirements:

  • HTML comment declarations are wrong. Use <!-- text --> instead of <!-----text------>
  • <form method="get" id="srform" action="<?php echo home_url(); ?> "/> has unnecessary / at the end.
  • js/menujs.js is an empty file, remove if it is not necessary.
  • <div id="post-<?php the_ID(); ?>"<?php post_class(); ?>> You need to add space after (id="php" post_class)
  • The post with no title doesnt have a link at blog index page.
  • Password protected post doesnt work properly. (2008/04/test-with-secret-password/ )
  • Image captions are not shown (2008/06/post-format-test-gallery/dsc20040724_152504_532/)
  • Comments arent shown in page with comments (page-with-comments/)
  • jQuery used in js/customjs.js but not loaded to the site. Page gives js error 2008/06/post-format-test-video/

Suggestions:

  • Add supported browser lists into readme.txt
  • Add bottom border too or different background to 2nd and 3rd level menus while on hover. Text with only top border is not user friendly.
  • Default menu font is not same with custom menu font. Use same font definitions.
  • Links have same color with content body. Change to different color or add underline.
  • Page with comments disabled should not display "No comment" message.
  • Trackbacks and Pingbacks should not display "Reply" link. (2008/03/comment-test/)
  • Author comments should be highlighted. (2008/03/comment-test/)
  • You should also add css styles to blockquote, table, ordered and unorderes lists, ins, pre, sub, sup in comments section.
  • There is no font and color harmony on links. Nav menu links, post links, tag links, category links, post content links, links in post content, sidebar tag links, sidebar calendar links and sidebar category links have diffent font face or color or hover effect or background color.
  • Add edit link to posts and pages.
  • Add link to authors and post/page dates.
  • Dont load jQuery just for one function. Use native javascript instead.

Notes:

  • No rtl support.
  • IE7 & IE8 gives javascript error.


comment:3 Changed 7 months ago by emiluzelac

  • Resolution set to not-approved
  • Status changed from assigned to closed

comment:4 in reply to: ↑ 2 Changed 7 months ago by jathin

Replying to trkr:

Hello,

Sorry for being a bit late .Thanks for reviewing the theme and giving the suggestions. I'll resubmit the theme after making the necessary changes.But before that could you please clarify the following,




1) "Password protected post doesnt work properly."

I typed 'secret'( which is supposed to be the password ) in the password field ,and was able to read the post. ('The password is secret.')


2)"Image captions are not shown (2008/06/post-format-test-gallery/dsc20040724_152504_532/)"

I checked it and the caption is visible ('Chunk of resinous blackboy husk, Clarkson, Western
Australia. This burns like a spinifex log.') .


3) IE7 & IE8 gives javascript error.

I'm using ie8 and checked the theme using compatibility mode and didn't get any error message.


Thank you.








Last edited 7 months ago by jathin (previous) (diff)
Note: See TracTickets for help on using tickets.