#9763 closed theme (live)
THEME: Leaf - 0.7
| Reported by: | bradthomas127 | Owned by: | wpcustom |
|---|---|---|---|
| Priority: | major | Keywords: | theme-leaf |
| Cc: | bradthomas127@… |
Description
Leaf - 0.7
The Leaf theme is a stylish and customizable WordPress? theme. Make it yours with the easy customizable theme options. Uses Superfish menu effects, built-in pagination for post pages, special styles for eight different post formats, and a responsive layout for mobile devices.
Theme URL - http://fatboythemes.com/themes/leaf/
Author URL - http://wp-ultra.com
SVN - http://themes.svn.wordpress.org/leaf/0.7
ZIP - http://wordpress.org/extend/themes/download/leaf.0.7.zip?nostats=1
All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-leaf
Change History (14)
comment:1 Changed 7 months ago by emiluzelac
- Owner set to wpcustom
- Status changed from new to assigned
comment:2 Changed 7 months ago by wpcustom
comment:3 Changed 7 months ago by emiluzelac
That should be good actually, unless this breaks things?
comment:4 Changed 7 months ago by bradthomas127
@wpcustom - Watch the doctype when validating.
@emiluzelac - The slider on the home page does fail HTML5 validation for the data- attribute.
comment:5 Changed 7 months ago by emiluzelac
@bradthomas127 W3C is recommended, but not required or something we should fail a Theme on :)
@wpcustom do you see anything else, or this is about it?
Thanks!
comment:6 follow-up: ↓ 7 Changed 6 months ago by bradthomas127
@wpcustom are you still working on this?
comment:7 in reply to: ↑ 6 Changed 6 months ago by wpcustom
Replying to bradthomas127:
@wpcustom are you still working on this?
Yes, what now? Has developer fixed and resubmitted? Not sure whats going on with this theme from the comments. Let me know please.
comment:8 Changed 6 months ago by bradthomas127
@emiluzelac
comment:9 Changed 6 months ago by emiluzelac
Hi @wpcustom,
What I would like to know if we can get more details about the Theme Review other than W3C recommendations, was there anything else in this Theme which would prevent the approval?
Thanks,
Emil
comment:10 Changed 6 months ago by wpcustom
@emiluzelac This is what I found
Doctype - add <html <?php language_attributes(); ?>> above <head>
style.css - Author URI: Needs to be on same domain as Theme URI Note: you can't have 2 different domains.
NOT SURE ABOUT THIS? should they remove credits in style.css ---
Resetting and rebuilding styles have been helped along thanks to the fine work of
Eric Meyer http://meyerweb.com/eric/tools/css/reset/index.html
along with Nicolas Gallagher and Jonathan Neal http://necolas.github.com/normalize.css/
and Blueprint http://www.blueprintcss.org/
Thanks
phil
comment:11 Changed 6 months ago by emiluzelac
Credit Links are good, there's only one if the footer area. Doctype looks ok as well, so if there's nothing else, should we approve?
Emil
comment:12 Changed 6 months ago by wpcustom
I didn't see anything else, everything works, nice theme - I think it should be approved
comment:13 Changed 6 months ago by emiluzelac
- Resolution set to approved
- Status changed from assigned to closed
thanks!
comment:14 Changed 6 months ago by bradthomas127
@wpcustom & @emiluzelac - Thank you for the review.
Not-Approved
Validate CSS code @ http://jigsaw.w3.org/css-validator/#validate_by_input
Validate XHTML (source code) @ http://validator.w3.org/#validate_by_input