THEME: Palmixio - 1.7.1

[colixio]

Palmixio - 1.7.1

WP theme with 2 column layout, theme options, custom header, post image thumbnail ready (only for Wordpress 2.9 or higher), widget-ready (sidebar and footer), custom gravatar, easy to customize, you can display a thumbnail into post, upload a image and display this in header, change background body and background header.

Theme URL - ​https://plus.google.com/u/0/102318524143554174846/about
Author URL -

SVN - ​http://themes.svn.wordpress.org/palmixio/1.7.1
ZIP - ​http://wordpress.org/extend/themes/download/palmixio.1.7.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/palmixio/1.7&new_path=/palmixio/1.7.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-palmixio&order=id

[colixio]

This file must replace replace gpl.txt

[emiluzelac]

Ticket was not reviewed within 7 days, reassigning to @SriniG
@colixio we cannot work with attachments, if something needs to be changed, please make sure that this is done via new submission. Let's wait for the preliminary review, just in case there's something else.

Thanks!

[SriniG]

Required

The issues below are required to be fixed before the theme can be approved.

Notices

Notice: Undefined variable: myalign in wp-content/themes/palmixio/options.php on line 255

This shows up immediately after the activation of the theme and disappears once you visit the front end. This error gets replicated every time the theme is freshly installed in a WordPress? set up. This must be fixed.

Theme Namespacing

Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries.

Functions with names oenology_enqueue_comment_reply(), new_excerpt_length(), new_excerpt_more(), and a global variable named $BgPalmixio are found in functions.php. There are also other such functions in options.php and also in files derived from the options framework plugin. All these functions and global variables must be renamed and be prefixed with a unique slug, such as 'palmixio'.

HTML Validation errors.

On line 34 of index.php, line 67 of archive.php, line 37 of single.php, the following code is found

<div class="post" id="post-<?php the_ID(); ?>" <?php post_class(); ?>>

This is wrong, and this throws up plenty of validation errors. Please refer ​http://codex.wordpress.org/post_class#Adding_More_Classes and do it the right way. In fact, post_class() automatically generates the class name 'post' along with other classnames, so you don't have to manually add it.

And the html validator throws up many other errors, mainly with reference to using the same id for different elements. Please check and fix the errors.

Translation calls

Translation/internationalization is completely optional, but if translation calls are used, it has to be done the right way. Translation function calls must NOT contain PHP variables.

For example, in line 213 of options.php,

'desc' => __(''.$tmedia.'', 'Palmixio')

You don't have to translate $media. Just 'desc' => $media would do.

And in line 218 of options.php,

__(''.$WPWPP.' Setting thumbnail height (150px by default).', 'Palmixio'),

This is not the right way to do it. You can do it as follows:

sprintf( __('%s Setting thumbnail height (150px by default).', 'Palmixio'), $WPWPP ),

There are few other instances of similar wrong usage of translation calls in options.php. All these must be fixed.

Theme Features

• comment_form() not found in comments.php. Themes are required to implement this WordPress? core feature.

• The theme makes use of the WP core feature 'custom background'. But the default background image shows in the front end even when the default bg image is removed in the settings.

Recommended

The following are recommendations, but not required for the theme to be approved.

• The theme uses a custom setting to upload a header image. It's recommended to use the WordPress? core feature add_theme_support('custom-header') for this functionality.

• In the settings page, there is an option to provide the IDs of pages the user want to display in the nav menu. It's recommended to use the WordPress? core feature wp_nav_menu() for this.

• The theme makes use of the post_thumbnails/Featured Image feature, but the featured image doesn't show up in single posts. Is this intended behaviour? If not, fix this.

Suggestions

Making the code more readable (with proper indentation, spacing between functions, inline documentation, etc.,) would be nice. Please refer ​http://codex.wordpress.org/WordPress_Coding_Standards.

[SriniG]

And regarding license.txt. The theme links to ​http://www.gnu.org/licenses/gpl-2.0.html in style.css for License URI, so including license.txt is not required, no harm including the file in the next update.