THEME: Columbus - 1.7

[Placester]

Columbus - 1.7

It goes without saying that the goal of a real estate website is to drive more leads. But what's the best way to do this? Is it better to dazzle visitors with digital velvet and mahoghany? Or should you ditch the expensive decor and let your inventory speak for itself? With Columbus, you don't have to choose. Columbus' borderless look will give your website an understated elegance, while its green and blue accents will make your listing details jump off the page. Perfect for both individual agents and single-office agencies, Columbus is ideal for displaying multiple property listings, with a two-column layout and top-level page navigation. It's also fully customizable, so you can make it your own, and SEO optimized, which means you’ll get even more compliments on your feng shui. Use with <a href="​https://placester.com/">Placester</a>'s <a href="​http://wordpress.org/extend/plugins/placester/">Real Estate Builder plugin</a>.

Theme URL - ​https://placester.com/wordpress-themes/columbus/
Author URL - ​https://placester.com

SVN - ​http://themes.svn.wordpress.org/columbus/1.7
ZIP - ​http://wordpress.org/extend/themes/download/columbus.1.7.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/columbus/1.6&new_path=/columbus/1.7

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-columbus&order=id

Theme Check

PASSED

Previous Issues

• REQUIRED: Since you are not supporting translation, remove translation functions "Theme Framework" supports translation, rest of the Theme not. This is pretty much a all or nothing decision (AFAIK). loop-entries.php still have functions. -- the older/newer entries links use (), which is a translation/textdomain function
• REQUIRED: No CSS files other than style.css are hard-coded into the document head. (These files must either be enqueued and hooked in appropriately, or added using IE conditional tags.) -- this refers to the theme options custom CSS, which should be enqueued in functions.php
• REQUIRED: No unnecessary meta tags (WordPress??? generator tag, SEO meta tags, copyright meta tags, etc.) are hard-coded into the document head. -- I'm going to assume from the previous reviewer's comment this refers to the author and description meta tags
• REQUIRED: Themes are required to use the add_theme_page() function to add the Theme Settings Page to the Appearance menu, rather than using add_menu_page() to add a top-level menu.

Code

• REQUIRED: wp_head should be called directly before the closing HEAD tag. Currently there is a function after wp_head() in header.php
• REQUIRED: Scripts are required to be enqueued and hooked into the appropriate action in functions.php -- there are currently several scripts enqueued directly in footer.php, should be hooked into wp_enqueue_scripts in functions.php instead
• REQUIRED: Many warnings on the home page upon activation:

  OTHER WARNINGS: 18
  -- Debug: Undefined index: classes on line 114 of /wp-content/themes/columbus/blueprint/extensions/image-util.php
  -- Debug: Undefined index: id on line 105 of /wp-content/themes/columbus/blueprint/functions/widgets/contact.php
  -- Debug: Undefined index: location on line 106 of /wp-content/themes/columbus/blueprint/functions/widgets/contact.php
  -- Debug: Undefined index: beds on line 389 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: min_beds on line 400 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: max_beds on line 410 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: baths on line 420 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: half_baths on line 430 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: property_type on line 441 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: listing_types on line 450 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: zoning_types on line 459 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: purchase_types on line 468 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: avail_on on line 477 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: min_price on line 522 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: max_price on line 532 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: min_price on line 541 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: max_price on line 551 of /wp-content/themes/columbus/blueprint/partials/get-listings-search-form.php
  -- Debug: Undefined index: classes on line 114 of /wp-content/themes/columbus/blueprint/extensions/image-util.php
  

• REQUIRED: More warnings when viewing a page:

  Debug: Array to string conversion on line 51 of /wp-content/themes/columbus/custom/property-details.php
  -- Debug: Undefined index: classes on line 114 of /wp-content/themes/columbus/blueprint/extensions/image-util.php
  

• REQUIRED: Theme is required to include WordPress?-generated CSS classes:

Caption Related Classes:
.wp-caption
.wp-caption-text
.gallery-caption
Post Classes:
.sticky
Comment Classes:
.bypostauthor

Theme Unit Test

• REQUIRED: Page content floats oddly next to the page title: ​http://www.evernote.com/shard/s213/sh/dee99310-18a4-4934-bc8c-2ce0729c8465/c381ce3dd40b172d7c26e8264036de4a
• REQUIRED: Comments area could use some cleanup with spacing and margins: ​http://www.evernote.com/shard/s213/sh/223be570-5e8f-4507-b8cc-26be569ff84f/4a5473cf6134fdd83e168cf844945184
• RECOMMENDED: H3's have an increased left margin, which looks odd compared to the rest of the heading tags... is this intentional? ​http://www.evernote.com/shard/s213/sh/0703dde7-82ac-47f0-8ef6-6e8e096115f3/66fc0c2f05acf1988bd705802dc730d4
• REQUIRED: Tables need styling
• REQUIRED: Category archives display no post content
• REQUIRED: Large images overflow content area: ​http://www.evernote.com/shard/s213/sh/b205461a-79f4-4f7a-9247-0ab3b5d98295/bea9255d729fbe69c4400e9c770f8fce Use max-width or overflow properties to control this
• REQUIRED: Single image attachment view (for example, when you click on a gallery item) displays no content
• REQUIRED: Search results page is messy and could use some styling -- links default to purple/blue colors, margins are off, etc.: ​http://www.evernote.com/shard/s213/sh/15f393ab-8646-4a25-889e-97245b9fb767/4df34622cc4edf2717d052eebebb36a2
• REQUIRED: Assigning a menu to the Subsidiary menu area does not appear to do anything on the front end of the theme
• REQUIRED: Widgets could use margins between, calendar widget needs styling: ​http://www.evernote.com/shard/s213/sh/88c32ae1-830f-48fe-99e9-8803b5b93ee1/064ad1a9f6597d36545335199daaf8a2
• REQUIRED: Large images overflow the sidebar widget area: ​http://www.evernote.com/shard/s213/sh/0fd75477-fa09-419a-ac66-be2e5931f59b/269af841804b9a035c3040756fb082ec
• REQUIRED: I was not able to get the Agent Widget to display

Recommendation

Thanks for submitting your theme! Marking as Not Approved for now. Please address any REQUIRED issues above and resubmit your theme. If you do so in the next 2-3 days, comment here with a link to the new ticket and I'll be happy to re-review. Thanks!

sixhours, apologies for the late reply. We have several themes submitted for the WordPress?.org Theme repository and have been actively working to get two of them in last week.

New ticket for Columbus is available here. It addresses the remarks from your review as well as several small additions from our team.