Context Navigation

← Previous Ticket
Next Ticket →

#9788 closed theme (not-approved)

THEME: Sukelius Magazine - 0.1.1

Reported by:	themesbros	Owned by:	Frank Klein
Priority:		Keywords:	theme-sukelius-magazine
Cc:	support@…

Description

Sukelius Magazine - 0.1.1

News / blogging theme, with theme options and content slider. Theme supports post formats, two nav menu locations, and one, two, and three-column layouts.There are 5 widget areas, built in popular widget, and it's child-theme friendly. Subsidiary sidebar is widget-width flexible, if you put one widget it'll be 100% wide, two widgets - 50% each, three widgets 30%... Max is 4 widgets per row. Feel free to do whatever you like with theme, and enjoy doing it!!

Theme URL - http://themehybrid.com/themes/sukelius-magazine
Author URL - http://www.themesbros.com

SVN - http://themes.svn.wordpress.org/sukelius-magazine/0.1.1
ZIP - http://wordpress.org/extend/themes/download/sukelius-magazine.0.1.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/sukelius-magazine/0.1&new_path=/sukelius-magazine/0.1.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-sukelius-magazine&order=id

Change History (5)

comment:1 Frank Klein — 8 months ago

Owner set to Frank Klein
Status changed from new to assigned

comment:2 Frank Klein — 8 months ago

Resolution set to not-approved
Status changed from assigned to closed

This is a preliminary review:

Screenshot

The screenshot is not an accurate representation of the theme after activation.

Style.css

The author of the theme should be mentioned under Author instead of using an URL.
The Author URI points to a temporary page for a premium theme shop. Unfortunately it's impossible to estimate at this point whether this URL is appropriate, so it shouldn't be used as Author URI.
The copyright needs to be declared according to the GPL. (http://codex.wordpress.org/Theme_Review#Licensing)

Various Issues

There is no fallback in case there is no custom menu defined.
The display of the main and secondary menu is broken if there are more menu items than fit on one line (CSS background-image issue)
Without the slider, the text logo "sticks" to the content area.
In the theme settings, when I check the box for using the slider, I get white screen of death with a PHP notice and a warning
The slider is displayed on the front end after this error message, but it doesn't work, since it pulls data from the sticky posts in the theme test content, but it falls finding the featured images to display.

Thank you for fixing these issues and submitting a new version for a more thorough review.

comment:3 themesbros — 8 months ago

Hi Frank, thank you very much for the review!

In order to do all this properly, I need your opinion on few things here.

The Author URI points to a temporary page for a premium theme shop. Unfortunately it's impossible to estimate at this point whether this URL is appropriate, so it shouldn't be used as Author URI.

Will this url do it - http://themehybrid.com/support/profile/sin? I don't have anything else wp related...

The copyright needs to be declared according to the GPL. (http://codex.wordpress.org/Theme_Review#Licensing)

I declared copyright in style.css, added credits for hybrid core framework I'm using, fonts and slider, you can see that in the docs/readme.html. I really don't know what I'm missing?

Without the slider, the text logo "sticks" to the content area.

I'm not sure what do you mean by this. Can you check the screenshot, and see if we're thinking on the same thing? http://postimage.org/image/j0vzf5ozh/full/
If I understood this properly, I should add margin-bottom?

There is no fallback in case there is no custom menu defined.

There is a bunch of themes here in the directory that are working this way, with no fallback. I could easily add wp_list_categories and wp_list_pages, it's not a problem.
But, all newer Justin Tadlock's themes here are working this way, with no fallback, plus other approved themes from the other authors here, too. This way, we don't force people to use 2 menu's if they don't need them. That's why I would rather keep it this way...

The same thing is with the screenshot. I mean, lot's of themes here are having sliders that are not enabled by default, but they are still on screenshots. It would look really empty without the slider and without both menu's on screenshot since they need to be created first... I hope you understand me.

Thank you again for reading, and for finding the bug in slider.

Best regards,
Sinisa

comment:4 Frank Klein — 7 months ago

Hi Sinisa,

thanks for getting back to me.

Will this url do it - http://themehybrid.com/support/profile/sin? I don't have anything else wp related...

The Author URI has to point to an "author's personal web site or project/development website", so I don't think that the Theme Hybrid would be appropriate, especially because the Theme URI already points to this website.

By the way there is nothing wrong with pointing to the website you indicated in the theme, as long as the website is not a temporary page that will surely change in the future.

As the Author URI is optional, we can remove it for the time being if this speeds up things.

I declared copyright in style.css, added credits for hybrid core framework I'm using, fonts and slider, you can see that in the docs/readme.html. I really don't know what I'm missing?

According to the Theme Guidelines, the copyright needs to be declared a certain way, so a little copy-paste should be all that is needed.

I'm not too sure about the automatically inserted copyright in the footer on the front-end as well, since the theme developer owns the copyright on the theme and not the blog owner.

I'm not sure what do you mean by this. Can you check the screenshot, and see if we're thinking on the same thing? http://postimage.org/image/j0vzf5ozh/full/
If I understood this properly, I should add margin-bottom?

The screenshot with the added margin looks much better, that was what I meant.

There is no fallback in case there is no custom menu defined.

This my bad actually, as I researched this in the Theme Review mailing list archives: http://lists.wordpress.org/pipermail/theme-reviewers/2011-August/006557.html

Here is what Chip says:

Note that it would be equally valid for the developer to fallback to *no menu displaying* if none is applied to the Theme Location - again, the key is that the behavior is documented, so that the end user knows what to expect

So having no fallback is OK if you stated this in your README. Sorry about that, definitely a wrong call on my part.

The same thing is with the screenshot. I mean, lot's of themes here are having sliders that are not enabled by default, but they are still on screenshots. It would look really empty without the slider and without both menu's on screenshot since they need to be created first... I hope you understand me.

I understand what you mean, so theme review guidelines state that the screenshot "Should be a "reasonable facsimile" of the Theme after it is initially activated with default options".

So on the screenshot you provided I see:

a grey menu bar with social icons
an ad banner
a black menu bar
a slider
a red "banner"

But after the activation I see no menus, no social icons, no ad banner and no red banner. So for me, the screenshot doesn't represent the theme with the default options accurately, since it looks nothing like the screenshot after activation.

I'm entirely with you on the point that the theme looks great on the screenshot, however the screenshot creates expectations for the user, and if the theme doesn't like reasonably like the preview after activation, the user might be disappointed.

I agree that his is kind of a grey area, but I'm pretty sure that my call is correct on this point. We can however check with a more experienced theme reviewer if you'd like to, just to be sure.

comment:5 themesbros — 7 months ago

Hi Frank,

thanks for answering. I made some changes, but I'm not sure is that it.

According to the Theme Guidelines, the copyright needs to be declared a certain way, so a little copy-paste should be all that is needed.

I added this to readme:

Sukelius Magazine Wordpress theme is licensed under the GNU General Public License, version 2 (GPL). Theme is distributed under the terms of the GNU GPL.

This theme is copyrighted to ThemesBros?.

I'm not too sure about the automatically inserted copyright in the footer on the front-end as well, since the theme developer owns the copyright on the theme and not the blog owner.

Blog owner doesn't owe my theme, true. But it's not declared that he does. It says Copyright - blog link - year. There's no mention of copyright of my theme or wp. On the RIGHT side yes, it says "Powered by WordPress? and Sukelius Magazine", but I copyright is not mentioned. Anyway, check Path, Cakifo, News themes in the directory. It's done the same way. I hope I helped.

I'm not sure what do you mean by this. Can you check the screenshot, and see if we're thinking on the same thing? http://postimage.org/image/j0vzf5ozh/full/

If I understood this properly, I should add margin-bottom?

The screenshot with the added margin looks much better, that was what I meant.

On this link http://postimage.org/image/j0vzf5ozh/full/ there's no margin bottom. Can you please post me a screenshot of what you see, maybe it's cross browser issue which I'm missing?

I added that there's no fallback for menu's in the readme, and that menu will not be displayed.

Screenshot:

I removed social icons, banner, slider, and I left menus. I would really love to leave slider on screenshot, but if you say so, ok. Let me know! Please note that lot's of themes do have it, and that even sidebars are shown on screenshots, but preview doesn't show any widgets in them... Let me know.