Opened 7 months ago

Closed 6 months ago

#9820 closed theme (not-approved)

THEME: Wispy Fish - 3.4.3

Reported by: micden.net Owned by: emiluzelac
Priority: major Keywords: theme-wispy-fish
Cc: admin@…

Description

Wispy Fish - 3.4.3

The 2012 Wispy Fish theme for WordPress? includes a Custom Header Image and Custom Header Text, and Custom Background Color. Width is fixed at 800px. There are extra widget areas two above and two below main content. Also four widget areas in footer. Theme Options for Posts, Pages, Menu, Sidebars, Excerpt, Footer, Advertisement, Comments and Featured Images.

Theme URL - ​http://display.micden.com/?theme=wispyfish
Author URL - ​http://www.micden.com

SVN - ​http://themes.svn.wordpress.org/wispy-fish/3.4.3
ZIP - ​http://wordpress.org/extend/themes/download/wispy-fish.3.4.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/wispy-fish/3.4.2&new_path=/wispy-fish/3.4.3

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-wispy-fish&order=id

http://themes.svn.wordpress.org/wispy-fish/3.4.3/screenshot.png

Change History (2)

comment:1 Changed 6 months ago by emiluzelac

  • Owner set to emiluzelac
  • Status changed from new to assigned

comment:2 Changed 6 months ago by emiluzelac

  • Resolution set to not-approved
  • Status changed from assigned to closed

This is a preliminary, visual review only!

header.php

  • Themes are required to ​enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function, rather than hard-coding stylesheet/script links or tags in the template.
  • Themes are required to use the Theme-specific hook for admin-enqueued scripts/stylesheets, e.g. admin_print_scripts-appearance_page_$menu_slug
  • Themes are recommended to hook stylesheet and script enqueue callbacks into wp_enqueue_scripts
  • Themes may optionally link the default stylesheet (style.css) directly in the document head, or via wp_enqueue_style(). Whichever method is used, the default stylesheet must be referenced via get_stylesheet_uri()

It refers to:

<!--[if IE 6]><link rel="stylesheet" href="<?php get_template_directory_uri(); ?>/style.ie6.css" type="text/css" media="screen" /><![endif]-->

<!--[if IE 7]><link rel="stylesheet" href="<?php get_template_directory_uri(); ?>/style.ie7.css" type="text/css" media="screen" /><![endif]-->

and

wp_enqueue_script('jquery');
<script type="text/javascript" src="<?php get_template_directory_uri(); ?>/script.js"></script>

jQuery also needs to be as an array, no need to call jQuery directly.

Remove the following:

<?php if(WP_VERSION < 3.0): ?>

<link rel="alternate" type="application/rss+xml" title="<?php printf(__('%s RSS Feed', THEME_NS), get_bloginfo('name')); ?>" href="<?php bloginfo('rss2_url'); ?>" />

<link rel="alternate" type="application/atom+xml" title="<?php printf(__('%s Atom Feed', THEME_NS), get_bloginfo('name')); ?>" href="<?php bloginfo('atom_url'); ?>" />

<?php endif; ?>

There's no need for and also we can have one fallback only. All < 3.0 should be removed from Theme in general. No legacies either sorry.

if (WP_VERSION < 3.0){

and ​feed links should be within functions.php such as:

add_theme_support('automatic-feed-links');

remove_action('wp_head', 'wp_generator');

Please don't remove WordPress? Generator, this needs to be up to the users :)

Body class:

<body <?php if(function_exists('body_class')) body_class(); ?>>

always exists, change this to:

<body <?php body_class(); ?>>

All styles are better off within the stylesheets

Such as:

$heading_tag = 'h1 style="margin-top:-10px;"'; ?>

<div style="float:left;">
<div style="float:left; margin-top:7px; padding-left:10px;">
<hr noshade="noshade" color="#21759b" size="1"  />

inlines styles and especially when they are within PHP will be impossible to override. Best way to handle this is to assign a class or an ID.

functions.php

Any and all references to any other Theme but this very own should be renamed and or removed:

twentyeleven_admin_header_style

theme-update-checker.php

Theme Updates other than WordPress? for WPORG Themes are not allowed. Once you upload newer version of your Theme, WordPress? will handle the rest, so it's not necessary.

comments.php

PHP $_SERVER


variables are ​not safe for use in forms, links and in this particular case not really needed.

if (!empty($_SERVER['SCRIPT_FILENAME']) && 'comments.php' == basename($_SERVER['SCRIPT_FILENAME']))

This was a preliminary, visual review only, more complete review is needed. Please fix all requirements before your next submission. If you have any questions please feel free to post them right here. Also check the ​guidelines as well.

Thanks!

Note: See TracTickets for help on using tickets.