THEME: Tampa - 1.7

[Placester]

Tampa - 1.7

Alas, not all of us can sell real estate in a place with nonstop sun, palm trees, and breathtaking vistas. No, some of us are forced to endure the cold, rain, snow, and general ickiness of the northern climes. But if you can’t head south, why not let south come to you? With its warm red, orange, and yellow hues, Tampa will have you and your site visitors wearing your Bermuda shorts, no matter what ungodly weather you’re having. Perfect for both individual agents and single-office agencies, Tampa is ideal for displaying and surfing multiple property listings, with clean lines, a two-column layout, and top-level page navigation. It’s also fully customizable, so you can make it your own, and SEO optimized, which means more sun on more happy faces. Use with <a href="​http://placester.com/">Placester</a>'s <a href="wordpress.org/extend/plugins/placester/">Real Estate Pro plugin</a>.

Theme URL - ​https://placester.com/themes/tampa
Author URL - ​https://placester.com/

SVN - ​http://themes.svn.wordpress.org/tampa/1.7
ZIP - ​http://wordpress.org/extend/themes/download/tampa.1.7.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-tampa

[SriniG]

All the issues below are required to be fixed before the theme can be approved.

• Please fix the error message that shows up everytime on visiting the theme options page. (see http://themes.trac.wordpress.org/attachment/ticket/9854/tampa_JSON_error.png)

• Global variable $api_whoami found in header.php line 7. This should be prefixed with the theme slug. Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.)

• add_theme_support( 'automatic-feed-links' ) not found in functions.php. Theme is required to incorporate this WordPress? core feature.

• $content_width not defined. Theme is required to define a content width in functions.php

• wp_footer() template tag must be placed immediately before </body> in footer.php

• These seems to be hard-coded script blocks in footer.php. Scripts and script file links must not be hard-coded into the footer. Themes are required to enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function.

• get_theme_data found in the file blueprint/extensions/options-framework/options-interface.php. (line 16 & 19) Deprecated since version 3.4. Use wp_get_theme() instead.

• The theme appears to use include or require (in many instances). If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead. Please install the theme check plugin and check your theme for the list of instances where include and required are used. Theme check also lists a number of other recommendations. Please pay attention to these and fix all the issues as appropriate.

• screenshot.png not found. While the theme does include a file named screenshot.jpg and it shows fine in wp-admin/themes.php, according to ​http://codex.wordpress.org/Theme_Review#Theme_Template_Files as well as ​http://codex.wordpress.org/Theme_Development#Screenshot, the screenshot should be in PNG format. (Note to admin: I'm not entirely sure about this. Please correct me if the screenshot file can be allowed in jpeg format.)

Note: This is not a complete review. After all the above issues are fixed, the theme should go through another round of review before it can be approved.

[Placester]

Hello SriniG,

Thank you for your review, we are actively working on publishing several themes in the WordPress?.org Theme repository. All of our themes utilize the same internal blueprint framework.

We have fixed the errors marked in the review above and improved the overall quality of the codebase. Several notes regarding some of the comments and our framework:

add_theme_support( 'automatic-feed-links' ) not found in functions.php

The add_theme_support for automatic-feed-links is added in blueprint/blueprint.php, line 306

$content_width not defined

It is also defined in blueprint/css/styles.php, line 19

get_theme_data found in the file blueprint/extensions/options-framework/options-interface.php. (line 16 & 19) Deprecated since version 3.4. Use wp_get_theme() instead.

The get_theme_data call is designed as a fallback after a function_exists(...) for wp_get_theme, so it's not called directly for 3.4 and above

The theme appears to use include or require (in many instances).

The framework is large (codebase wise) and there are numerous includes for the setup.

The new version is submitted here - http://themes.trac.wordpress.org/ticket/10195 . We look forward to getting the next review and add several of our themes in the Extend repository.