Opened 7 months ago

Closed 5 months ago

#9856 closed theme (approved)

THEME: SemPress - 1.2.0

Reported by: pfefferle Owned by: uniquecoder
Priority: major Keywords: theme-sempress
Cc: pfefferle@…

Description

SemPress? - 1.2.0

A highly semantic, HTML5 template, responsive and seo optimized. SemPress? supports most of the new HTML5 tags, the new HTML5 input-types, microformats, microformats v2 and microdata (Schema.org).

Theme URL - https://github.com/pfefferle/SemPress
Author URL - http://notizblog.org/

SVN - http://themes.svn.wordpress.org/sempress/1.2.0
ZIP - http://wordpress.org/extend/themes/download/sempress.1.2.0.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/sempress/1.1.0&new_path=/sempress/1.2.0

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-sempress&order=id

http://themes.svn.wordpress.org/sempress/1.2.0/screenshot.png

Change History (10)

comment:1 Changed 6 months ago by emiluzelac

  • Owner set to uniquecoder
  • Status changed from new to assigned

comment:2 Changed 6 months ago by uniquecoder@…

Hi,
Please do following changes.

RECOMMENDED: No reference to add_theme_support( 'custom-header', $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

RECOMMENDED: No reference to add_theme_support( 'custom-background', $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

comment:3 Changed 6 months ago by pfefferle

Hey,

but the theme doesn't support any of these functionalities.

By the way, there is a new version of the theme, with some small CSS changes: http://themes.trac.wordpress.org/ticket/10056

comment:4 Changed 6 months ago by uniquecoder@…

Hi,

You need to add that in your function.php file.

comment:5 Changed 6 months ago by pfefferle

Hey,

Why do I have to? There are several Themes that doesn't support background images. And the guidline says it is RECOMMENDED IF the theme does support it.

comment:6 Changed 6 months ago by pfefferle

...from the guideline: http://codex.wordpress.org/Theme_Review#Theme_Features

Theme is recommended to incorporate the following WordPress? core features, but is not required to do so. However, if incorporated, features must support the core WordPress? implementation

Last edited 6 months ago by pfefferle (previous) (diff)

comment:7 follow-up: Changed 6 months ago by emiluzelac

Recommended but not required ;) Is there anything else that you can find, other than this?

comment:8 in reply to: ↑ 7 Changed 6 months ago by uniquecoder@…

Replying to emiluzelac:

Recommended but not required ;) Is there anything else that you can find, other than this?

HI Emil,
Nope nothing. I also check with Exploit scanner and it pass that too.

Though I found one UI issue in IE7 where Leve2 and Level 3 links are not clickable by user.

We can approve this theme if you think that we don't support IE7.

Let me know what do you think.

Thanks,
Himanshu

comment:9 Changed 5 months ago by uniquecoder@…

Hi Emil,

Can we close this ticket.

comment:10 Changed 5 months ago by emiluzelac

  • Resolution set to approved
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.