Change History (8)

comment:1 Changed 6 months ago by emiluzelac

  • Owner set to labor4it
  • Status changed from new to assigned

comment:2 Changed 6 months ago by labor4it

Theme Check: Passed
Debogger Test: Passed

Code Quality
Recommended: add_custom_image_header found in the file custom-header.php. Deprecated since version 3.4. Use add_theme_support( 'custom-header', $args ) instead

Required: Themes are required to use theme-slug (or a reasonable facsimile) as textdomain for translation. Ref: image.php

Presentation vs Functionality
Required: Theme may optionally incorporate translation/internationalization; however, if incorporated, translation/internationalization must support WordPress? core functionality. You should include a translation file in your language folder.

WordPress?-Generated CSS Classes
Required: Themes are required to support the WordPress?-defined CSS classes, or similar elements. The .gallery-caption should not be empty. Tag s should be styled.

Theme Template Files
Required: Theme's screenshot.png is 600:450px. The Maximum size should be 320:240px.

Proposed Resolution: Not-Approved
Please address the required issues in next theme version.

Last edited 6 months ago by labor4it (previous) (diff)

comment:3 Changed 6 months ago by sixhours

Hi @labor4it! Thanks for the review.

I'm following the new guidelines here for retina-ready/hi-DPI screenshots: http://core.trac.wordpress.org/ticket/21388

This may not have made it into the review docs yet, but I believe 600x450 is an appropriate screenshot size now.

I'll fix the rest and post it here -- would you be willing to re-review it if I do so today?

comment:4 Changed 6 months ago by labor4it

@sixhours

I shall if I be assigned for that ticket :)

Last edited 6 months ago by labor4it (previous) (diff)

comment:5 Changed 6 months ago by sixhours

I can assign you to the ticket if you like. Usually there's a 2-3 day grace period from the time you've completed the review for the developer to make the required changes.

No rush, though. I appreciate it! New ticket is here: #9975

comment:6 Changed 6 months ago by emiluzelac

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed

Assigned :)

comment:7 Changed 6 months ago by labor4it

@Emil

What size should be followed for the screenshot.png? The Theme Review Guideline or the size mentioned by sixhours referencing the support ticket http://core.trac.wordpress.org/ticket/21388 ?

Please make your suggestion.

Note: See TracTickets for help on using tickets.