THEME: Manchester - 1.7

[Placester]

Manchester - 1.7

The saying goes that cleanliness is next to godliness. Unfortunately, searching the web for a new home can be a dirty (and, occasionally, hellish) business. Why not help your users clean up the mess with a tidy real estate website? Manchester’s bright, simple feel, neat borders, and red and blue accents will give your cleaning lady a run for her money and your visitors a zenlike user experience. Perfect for both individual agents and single-office agencies, Manchester is ideal for displaying and surfing multiple property listings, with neat borders, a two-column layout, and top-level page navigation. It’s also fully customizable, so you can make it your own, and SEO optimized, which means more chances to show off your properties. If only it were that easy to get the pet stains out of your carpet… Use with <a href="​https://placester.com/">Placester</a>'s <a href="wordpress.org/extend/plugins/placester/">Real Estate Builder plugin</a>.

Theme URL - ​https://placester.com/themes/manchester
Author URL - ​https://placester.com/

SVN - ​http://themes.svn.wordpress.org/manchester/1.7
ZIP - ​http://wordpress.org/extend/themes/download/manchester.1.7.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-manchester

[Sanjiv Saha]

Theme Check Plugin: Pass
Deprecated Notices Plugin: Pass
Theme Unit Test Data: Pass
Debogger Plugin: Pass

Required

• Themes are required to use to get_stylesheet_uri() rather than get_template_directory_uri() to link the default stylesheet(style.css).
  • Note: The header part is linking the style.css file inside of the css folder rather it should link the main style.css file.
• Correct content-type meta declaration: <meta http-equiv="Content-Type" content="<?php bloginfo('html_type'); ?>; charset=<?php bloginfo('charset'); ?>" /> OR <meta charset="<?php bloginfo('charset'); ?>" /> declared before <title>
• Themes are required to enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function, rather than hard-coding stylesheet/script links or tags in the template.
  • script.js file is hard-coded in footer.php. Use wp_enqueue_script() and hook it in wp_footer hook.
  • blueprint/templates/home.php file has scripts hard-coded in it. Make a .js file and enqueue it properly.
  • Check if other php files have scripts hard-coded and use wp_enqueue_script for theme as well.
• If incorporated into the Theme, standard template files are required to be called using the correct template tag.
  • header.php (via get_header())
  • footer.php (via get_footer())
  • sidebar.php (via get_sidebar())
• Add the screenshot image of the theme in png format.
• The upload button in the theme option does not seem to work. Fix it.

Suggestions

• Recommended ratio for screenshot is 4:3 W:H (300x225px).
• Add supported browsers list into readme file.

[emiluzelac]

Re-opening this ticket @Sanjiv Saha if you wish to wait till newer version is uploaded please do and you can assign new ticket on your own, I will bump your status to full reviewer :)

Thanks,
Emil

[Sanjiv Saha]

Some more issue to be fixed:

• Please fix the error message that shows up everytime on visiting the theme options page.
  • DataTables? warning: JSON data from server could not be parsed. This is caused by a JSON formatting error.
  • Note: You have fixed this error in your other theme tampa, fix it here as well.
• Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.)
  • Themes are recommended to use theme-slug as this unique slug
  • Note: I see you have used options framework and blueprint framework. So, you don't need to use theme namespacing for them( as it will be very difficult), but please use theme namespacing in the other files which do not relate to these framework.

@Placester

I am keeping this ticket open for few days. You can fix these above mentioned issues and comment your updated version below. I will look into as quickly as possible and approve it after they are fixed. :) I see you have used the OOP programming style so please tell if above some issues are difficult to fix, I will consider and look what can be done.

Thanks,
Sanjiv

[Placester]

Hey Sanjiv,

New version is available here. All remarks for the theme and the framework based on previous reviews have been addressed. Hopefully we could contribute another theme to the WordPress?.org repository.

Placester