THEME: Business Casual Portfolio - 0.1

[austinpickett]

Business Casual Portfolio - 0.1

A Pretty Standard Business Theme

Theme URL -
Author URL - ​http://austinkpickett.com

SVN - ​http://themes.svn.wordpress.org/business-casual-portfolio/0.1
ZIP - ​http://wordpress.org/extend/themes/download/business-casual-portfolio.0.1.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-business-casual-portfolio

[saltcod]

Required

---

GENERAL
==============

— lots of use of !important in styles
— unsytled links in the footer
— Pagination not using next/prev
— no way to navigate between posts when viewing a single post
— Comments not showing up on blog posts
— Top menu is hard-coded — no way for user to replace the top menu with their own menu
— Menu doesn't support dropdowns
— theme contains a mysterious "crossdomain.xml" file
— theme contains custom-style.css file, which never gets @imported or referenced in header.php
— theme uses out-dated version of jQuery and jQuery Cycle
— Loads Chrome Frame — this ok?
— Theme includes a 500 line .htaccess file!
— no 404 page — 404 is here as a .html file with lots of inline styles. Needs to be fixed.
— tag archives page doesn't seem to work
– screenshot.png is the wrong size
— header calls: ( ! isset( $content_width ) ) $content_width = 900; -> This should be in functions.php
— Archives pages don't provide context — when you look at the archives for May 2008, there should be a title / description telling the user what they're looking at.
— Links in the footer / footer widgets are unstyled: ​http://cl.ly/image/0v1k3F3l0208
— Running through the theme unit test should highlight all of these issues for you: ​http://codex.wordpress.org/Theme_Unit_Test

SEARCH
========
— No context when on search results page — search term is not shown on the page anywhere
— No 'No search results found' message
— Post title should be linkable on the seach results page

SCRIPTS
=========

— Enqueue scripts in functions.php rather than script src'ing them in footer.php and header.php. ​http://codex.wordpress.org/Function_Reference/wp_enqueue_script will show you how. Using wp_enqueue_script, you can set a script to be loaded in the footer or the header
— Your call to the jQuery cycle plugin should be moved from header.php to /js/script.js
— theme contains 3 instances of jQuery

IMAGES
========
— Images not properly aligned — center/left/right all look the same
— large images bust out of their container. Setting a max-width on images in the content area should fix this. ​http://cl.ly/image/0o47061G2w2k

WIDGETS
========
— When you add a new sidebar widget to the Testimonials sidebar, it gets housed in a new #sidebar div. IDs should only be used once per page

— Widgets should be more general purpose — perhaps a main sidebar widget instead of the 'Testimonials' widget.

— not enough styling around the 'Spotlight Elements' widget area — ​http://cl.ly/image/191N3O3m3o3s

— Widgets with links (Custom Menu widget for example) are unstyled in the Testimonials sidebar — ​http://cl.ly/image/191N3O3m3o3s

— Widgets do not float properly — when you add 3-4 sidebar widgets, the layout will break and widgets will flow into the content area. ​http://cl.ly/050x3g1s0T3q

LAYOUT TEST
============
— no table styling
— lots of float issues – clearfix class exists in style.css, but isn't in the markup

[emiluzelac]

Theme not approved per above review. Please correct the requirements and feel free to resubmit :) We can also do a grace period of couple of days if needed.

[emiluzelac]

P.S. Still active by the way.

[saltcod]

Replying to emiluzelac:

P.S. Still active by the way.

Hey @emiluzelac. Not sure what you mean by 'still active'. This ticket? Do I need to close it? Or does it stay open until revisions are made?

[austinpickett]

Please keep this active, I'll upload revisions tonight.

[emiluzelac]

8 days are passed cannot see new version? Let me know :)