WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

#10139 closed theme (closed-newer-version-uploaded)

THEME: F2 - 2.0.1

Reported by: SriniG Owned by: Sanjiv Saha
Priority: Keywords: theme-f2
Cc: serenesrini@…

Description

F2 - 2.0.1

A light-weight, responsive theme for WordPress. Widgetized sidebar, optional additional sidebar, four color schemes to choose from, and many other options. F2 2.0 requires WordPress version 3.4 or above. IMPORTANT NOTE: F2 version 2.0 is a massive update, a complete overhaul. If you are using an older version of the theme, mind that you will have to redefine all your customizations when you upgrade.

Theme URL - http://srinig.com/wordpress/themes/f2/
Author URL - http://srinig.com/

SVN - http://themes.svn.wordpress.org/f2/2.0.1
ZIP - http://wordpress.org/extend/themes/download/f2.2.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/f2/2.0&new_path=/f2/2.0.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-f2&order=id

https://themes.svn.wordpress.org/f2/2.0.1/screenshot.png

Attachments (2)

imagetest.PNG (157.1 KB) - added by Sanjiv Saha 5 years ago.
clearingfloat.PNG (307.1 KB) - added by Sanjiv Saha 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @Sanjiv Saha
5 years ago

  • Owner set to Sanjiv Saha
  • Status changed from new to accepted

@Sanjiv Saha
5 years ago

#2 @Sanjiv Saha
5 years ago

Theme Check Plugin:Pass
Deprecated Call Plugin:Pass
Theme Unit Test Data:Some issues listed below

Required

  • In the theme-options.php file there is following script. Rather make a js file and enqueue it properly.
    <script type="text/javascript">
    	( function( $ ){
    		wp.customize( 'f2_theme_options[color_scheme]', function( setval ) {
    			setval.bind( function( opt ) {
    				$('body').removeClass('color-scheme-blue');
    				$('body').removeClass('color-scheme-brown');
    				$('body').removeClass('color-scheme-green');
    				$('body').removeClass('color-scheme-dark');
    				$('body').addClass('color-scheme-'+opt);
    			});
    		});
    		wp.customize( 'f2_theme_options[sidebar_width]', function( setval ) {
    			setval.bind( function( opt ) {
    				$('body').removeClass('narrow-sidebar');
    				$('body').removeClass('medium-sidebar');
    				$('body').removeClass('wide-sidebar');
    				$('body').addClass(opt+'-sidebar');
    			});
    		});
    		wp.customize( 'f2_theme_options[sidebar_font_size]', function( setval ) {
    			setval.bind( function( opt ) {
    				$('body').removeClass('smaller-font-sidebar');
    				$('body').removeClass('small-font-sidebar');
    				$('body').removeClass('medium-font-sidebar');
    				$('body').removeClass('large-font-sidebar');
    				$('body').removeClass('larger-font-sidebar');
    				$('body').addClass(opt+'-font-sidebar');
    			});
    		});
    		wp.customize( 'f2_theme_options[content_font_size]', function( setval ) {
    			setval.bind( function( opt ) {
    				$('body').removeClass('smaller-font-content');
    				$('body').removeClass('small-font-content');
    				$('body').removeClass('medium-font-content');
    				$('body').removeClass('large-font-content');
    				$('body').removeClass('larger-font-content');
    				$('body').addClass(opt+'-font-content');
    			});
    		});
    	} )( jQuery )
    	</script>
    
  • I have attached an image imagetest.png. Image is 900x598px, it should be resized in editor to 329×222. It is not resized.
  • See the attached image clearingfloat.png. The edit button after the image is not cleared properly.

Suggestion

  • The style.css file is empty. Rather than enqueing the style file print.css and screen.css better import it from the style.css file. It is just my opinion as there is style.css file but as it is looking like it has no use.

@SriniG

Hi, I am keeping the ticket open. Fix the issue and submit new version and new ticket. Comment the ticket here below. I will look into it. I really like the theme. :)

Sanjiv

#3 @SriniG
5 years ago

Sanjiv, thanks for the review.

The code you mentioned is not hard-coded in any template file (theme-options.php is not a template file). It's only hooked on to wp-footer, which is perfectly fine as far as I know. Anyway, since you brought this up -- and, separating the code into a js file and enqueueing it is a very good practice --, I have made the change you suggested :)

Issues regarding image resized in editor and clearfloats are fixed.

And regarding style.css, I thought of doing it as you mentioned, but decided to keep it in css folder to keep it better organized as I'm using sass, so I'm keeping it that way.

New ticket: http://themes.trac.wordpress.org/ticket/10296

Thanks!

#4 @Sanjiv Saha
5 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.