WordPress.org

Make WordPress Themes

#10146 closed theme (live)

THEME: D5 Design - 1.01

Reported by: d5creation Owned by: Sanjiv Saha
Priority: Keywords: theme-d5-design
Cc: support@…

Description

D5 Design - 1.01

Design is CSS3 Powered super elegant and Professional Responsive Theme. Design is for Smart Companies and Persons who love to innovate. Customizable Background and Them Options will give the WordPress Driven Site an attractive look. Right and Footer Sidebar will be usable for showing the widgets. Full Wide page can be used for showing showcase or other pages. Pro version of Design Theme has more than 100 Options which will give you the opportunity to customize almost all the features of this Theme with extra functionality. A demo of Design Theme can be found here: http://demo.d5creation.com/wp/themes/design.

Theme URL - http://d5creation.com/theme/design/
Author URL - http://d5creation.com/

SVN - http://themes.svn.wordpress.org/d5-design/1.01
ZIP - http://wordpress.org/extend/themes/download/d5-design.1.01.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/d5-design/1.0&new_path=/d5-design/1.01

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-d5-design&order=id

https://themes.svn.wordpress.org/d5-design/1.01/screenshot.png

Attachments (1)

design-theme.PNG (148.1 KB) - added by d5creation 17 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 emiluzelac17 months ago

  • Owner set to Sanjiv Saha
  • Status changed from new to assigned

comment:2 Sanjiv Saha17 months ago

Previous Required Issues

  • Search Form problem in search.php file.(Fixed)
  • Many menu items problem. (Fixed)
  • Theme Namespacing: I see that you have used options plugin framework. You have used this framework in your previous themes which are already approved. So, this is okay for me. I leave this for the the admin.
  • Custom Header Problem: I could not find the problem in the another testing environment, so guess the problem was with my previous testing environment. (Fixed)
  • Custom Background Problem: (you could just write that the background color change will only take effect in header and content part not in the footer part in readme.txt file, just as you did for the many menu items limitation.(Not Fixed)
  • Themes are required to use the checked() and selected(). As this is also related to options plugin framework. This is also okay to me and leave this also to admin. I still recommend to use it.
  • I see the following code in files like index.php, blog.php and others as well. (Not Fixed)
    <div class="alignleft"><?php previous_posts_link('&laquo; Previous Entries') ?></div>
    <div class="alignright"><?php next_posts_link('Next Entries &raquo;','') ?></div>
    
    • Note: previous_posts_link is used to show Newer Entries and next_posts_link is used to show Older Entries. You are doing it right logically, but the names Previous Entries and Next Entries do not suit the respective links. You might want to use Newer Entries in place of the Previous Entries and Older Entries in place of the Next Entries. You might also want to swap the classes for those two divs. Please refer to twentytwelve theme to be more clear on what I am saying.

@d5creation

If you quickly fix these remaining issues, I will recommend for the resolution to be approved. :)

d5creation17 months ago

comment:3 d5creation17 months ago

Hello Sanjiv,

Thank you for your prompt response. Your recommendations are good and we will incorporate these in our next theme version. The custom background option is recommended, not required as we know. Though we see that this is working perfectly. The footer background is a part of theme design which should not be changed to keep the theme design as it is. Please see the attached image and you will find that the background color changing is working perfectly.

Previous Post Link and Next Post Link is using in this way because the posts are stored in descending way to the database. We think that it is not a major issue how the theme designers are designing these features, the required issue is to implement these features.

So, you may consider recommending the approval of this theme.

Thanking You

D5 Creation Team

comment:4 Sanjiv Saha17 months ago

Hi D5 Creation Team

The custom background option is recommended, not required as we know. Though we see that this is working perfectly. The footer background is a part of theme design which should not be changed to keep the theme design as it is. Please see the attached image and you will find that the background color changing is working perfectly.

It is okay to have footer color as you want as it is your theme :). What I am trying to say here is when users are changing the background color, they may think why the footer part is not changing. So, just keep a note in readme.txt file to remove their confusion.

Previous Post Link and Next Post Link is using in this way because the posts are stored in descending way to the database. We think that it is not a major issue how the theme designers are designing these features, the required issue is to implement these features.

Yes, you can do it in your own way. I am suggesting you the best way only as we are here to help increase the code standards.

You can implement these in the your next version update. :)

Recommended Resolution: Approved

comment:5 emiluzelac17 months ago

  • Resolution set to approved
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.