WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10534 closed theme (live)

THEME: Spartan - 1.0.1

Reported by: tskk Owned by: jcastaneda
Priority: Keywords: theme-spartan
Cc: tskk79@…

Description

Spartan - 1.0.1

Responsive wordpress magazine theme with 3 home page layouts, 2 page layouts including a full width page template, featured posts, social icons, twitter updates, threaded comments, custom background and widget support.

Theme URL - http://www.themealley.com/Spartan/
Author URL - http://www.themealley.com/

SVN - http://themes.svn.wordpress.org/spartan/1.0.1
ZIP - http://wordpress.org/extend/themes/download/spartan.1.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/spartan/1.0.0&new_path=/spartan/1.0.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-spartan&order=id

https://themes.svn.wordpress.org/spartan/1.0.1/screenshot.png

Change History (5)

#1 @tskk
5 years ago

Required

Says translation ready but I didn't see load_theme_textdomain(), a languages folder or a Text Domain declaration in style.css ​Language
Removed the tag, will add it in next version

Post thumbnails: I did not see the function the_post_thumbnail() see ​Post Thumbnails (use of core implementation)
Already using it

HTML errors created were WordPress? related except for a stray <span> tag in single.php ( post_links section )
Fixed it

Suggestions

Consider using a conditional so that way a visitor doesn't see the notice about no menu selected. ​current_user_can('edit_theme_options')
Done

The favicon link meta tag shows up in the lite version consider removing that
Removed it

Consider adding suport for custom-backgrounds and visual editor
Added custom background, will visul editor in next version

Menu CSS. Sorry it kept bugging me because it seems to bring down the submenu by one pixel on every level as you add more levels. see attached image.
Done

#2 @jcastaneda
5 years ago

  • Owner set to jcastaneda
  • Status changed from new to accepted

#3 @jcastaneda
5 years ago

Required

All resolved

#4 @jcastaneda
5 years ago

  • Resolution set to approved
  • Status changed from accepted to closed

#5 @tskk
5 years ago

Thanks Jose, Have a rocking 13

Note: See TracTickets for help on using tickets.