WordPress.org

Make WordPress Themes

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#10539 closed theme (not-approved)

THEME: Falla - 1.0

Reported by: xiaohudie Owned by: chipbennett
Priority: Keywords: theme-falla
Cc: 9604149@…

Description

Falla - 1.0

A simple neat theme with custom functions, compatible with some basic plugins .

Theme URL - http://wordpress.org/extend/themes/falla
Author URL - http://xiaohudie.net/

SVN - http://themes.svn.wordpress.org/falla/1.0
ZIP - http://wordpress.org/extend/themes/download/falla.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-falla

https://themes.svn.wordpress.org/falla/1.0/screenshot.png

Attachments (1)

falla.zip (136.6 KB) - added by xiaohudie 16 months ago.
the approved one

Download all attachments as: .zip

Change History (4)

comment:1 chipbennett16 months ago

  • Owner set to chipbennett
  • Status changed from new to assigned

comment:2 chipbennett16 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Required

  • Screenshot is too large
  • HTML document title must be modified via the wp_title filter, rather than hard-coded inside the HTML <title> tag, which should be only: <title><?php wp_title( $args ); ?></title>
  • Set $content_width inside of a callback, hooked into after_setup_theme
  • Use get_template_directory() instead of TEMPLATEPATH
  • All custom functions must be prefixed uniquely, i.e. with some reasonable approximation of theme-slug (i.e. falla)
  • Code derived/borrowed from another work (such as Twenty Eleven) must be referenced, with original copyright/license declared

Recommended

  • phpDoc comments should be in English
  • Rather than incorporate Pagenavi Plugin, integrate support for the Plugin's function (e.g. via an if ( function_exists( 'pagenavi' ) ) conditional)

This is not a complete review.

xiaohudie16 months ago

the approved one

comment:3 xiaohudie16 months ago

Screenshot set to 600*450px;
<title>set to default layout (header.php);
Set $content_width inside after_setup_theme(function.php);
remove TEMPLATEPATH (function.php);
phpDoc comments in English(function.php);
Some changes and bug fixes.

Note: See TracTickets for help on using tickets.