WordPress.org

Make WordPress Themes

Opened 16 months ago

Closed 16 months ago

Last modified 15 months ago

#10552 closed theme (not-approved)

THEME: Reuben - 2.0

Reported by: cbfreeman Owned by: chipbennett
Priority: Keywords: theme-reuben
Cc: craigbfreeman@…

Description

Reuben - 2.0

Minimalistic theme with fixed layout. The main features include a featured content slider, custom front page template, 3 widget areas, custom header and 1 menu.

Theme URL - http://cbfreeman.com/reuben/
Author URL - http://cbfreeman.com

SVN - http://themes.svn.wordpress.org/reuben/2.0
ZIP - http://wordpress.org/extend/themes/download/reuben.2.0.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/reuben/1.0&new_path=/reuben/2.0

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-reuben&order=id

https://themes.svn.wordpress.org/reuben/2.0/screenshot.png

Change History (3)

comment:1 chipbennett16 months ago

  • Owner set to chipbennett
  • Status changed from new to assigned

comment:2 chipbennett16 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed
  • Footer credit link must be either Theme URI or Author URI.
  • Readme instructions for front-page.php template file usage are incorrect. The front-page.php template file is part of the core template hierarchy, and will be used on the site front page, regardless of any user configuration. If the Theme is intended to be used only with a static front page, please clarify this design decision in the readme docs.
  • Also in front-page.php, you should call wp_reset_postdata() rather than wp_reset_query(). The latter is only required when modifying the main query.
  • Also in front-page.php, call get_header( 'front' ), rather than get_template_part( 'header-front' )
  • Call to wp_head() must come immediately before closing HTML </head> tag
  • HTML document title content must be output via wp_title() only. Rather than hard-coding other content inside HTML <title> tags, add this content to wp_title() via the wp_title filter.
  • All remove_action( 'wp_head', $callback ) calls in functions.php are Plugin territory.
  • All Theme functions must be uniquely prefixed with a reasonable approximation of theme-slug'

This is not a complete review.

comment:3 cbfreeman15 months ago

Hi, Chip

ALL CHANGES MADE - SEE VERSION 2.1

THANKS

Note: See TracTickets for help on using tickets.