WordPress.org

Make WordPress Themes

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#10574 closed theme (closed-newer-version-uploaded)

THEME: Mimbolove - 1.0.4

Reported by: venkrao Owned by: chipbennett
Priority: Keywords: theme-mimbolove
Cc: venkatakrishnarao.ks@…

Description

Mimbolove - 1.0.4

Mimbolove is a simple, customizable theme for WordPress with support for custom menu, header image, two column layout, footer sidebar. Sticky post support, and Gallery, Image post formats, featured images are some of the other features supported. Mimbolove is suitable for those who write more on their blog, and also for those who publish photos.

Theme URL - http://mimbolove.wordpress.com
Author URL - http://slatebalapa.wordpress.com/about/

SVN - http://themes.svn.wordpress.org/mimbolove/1.0.4
ZIP - http://wordpress.org/extend/themes/download/mimbolove.1.0.4.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/mimbolove/1.0.3&new_path=/mimbolove/1.0.4

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-mimbolove&order=id

https://themes.svn.wordpress.org/mimbolove/1.0.4/screenshot.png

Change History (7)

comment:1 venkrao16 months ago

Only 2 changes have been made.

  • functions.php - "?>" added at the end of the file - I noticed that some of the users who used this theme have got seen an error "Cannot modify header information - headers already sent" This seemed to be resulted because functions.php was missing the closing "?>" , although when the theme is tested locally, this was never seen.
  • style.css - Author URL updated.

comment:2 chipbennett16 months ago

  • Owner set to chipbennett
  • Status changed from new to assigned

comment:3 chipbennett16 months ago

Previous-ticket required issue regarding copyright/license declaration not addressed. Please address, and re-submit the Theme as necessary. I'll hold this ticket open in the meantime. Please comment here with a link to the new ticket once you've re-submitted.

Note: regarding the "headers not sent" error, the more-likely culprits are found internally in functions.php, particularly, the closing PHP tag after the doc-level phpDoc, followed by newlines and an opening PHP tag.

Basically, look for anywhere that you have only whitespace or newlines between a closing PHP tag and another opening PHP tag, and remove both the closing and opening PHP tag in such locations.

There are two here:

<?php
/**
 * Defines various theme specific functions,
 * Implements WordPress standard hooks
 * Enables various WordPress functionalities.
 *
 * @package Mimbolove
 * @since Mimbolove 1.0.2
 */
?>

<?php 
	if ( ! isset( $content_width ) ) 
		$content_width = 775; 
?>
<?php

I would recommend removing the final, closing PHP tag from the file, as having it there is more likely to case "headers already sent" errors.

comment:4 venkrao16 months ago

Thank you for picking up the review so quickly.

New ticket is : http://themes.trac.wordpress.org/ticket/10586

I'd to make few more changes along The following are the changes compared with the version that is live.

  • Copyright information added in readme.txt
  • Support for custom background added
  • The unnecessary or troublesome closing/opening php tags have been removed from functions.php. I could find two instances of such tags.
  • mimbolove_next_prev_post_titles() - to print next/previous post title on single post page - added
  • Default header images - added
  • style.css - I'd to change the layout of the theme, as I wasn't convinced with the old one.

comment:5 chipbennett16 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed

comment:6 venkrao16 months ago

Hi Chip, Yes

  • Copyright information added in readme.txt

comment:7 chipbennett16 months ago

@venkrao:

Sorry, that was a comment for the Reviewer who reviewed the subsequent ticket, to verify that the change was made.

Note: See TracTickets for help on using tickets.