WordPress.org

Make WordPress Themes

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#10822 closed theme (not-approved)

THEME: canvas - 1.0.1

Reported by: amdhas Owned by: chipbennett
Priority: Keywords: theme-canvas
Cc: hasilent00@…

Description

canvas - 1.0.1

Canvas is a revolution theme for wordpress, which uses the method hook actions. Canvas wordpress theme designed to enable the manufacture of child theme. If you are looking for a theme that is simple, clean and minimalist canvas is a real theme to it. Canvas theme has only one file index.php is very minimal but it has many functions.

Theme URL -
Author URL - http://amdhas.com

SVN - http://themes.svn.wordpress.org/canvas/1.0.1
ZIP - http://wordpress.org/extend/themes/download/canvas.1.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/canvas/1.0.0&new_path=/canvas/1.0.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-canvas&order=id

https://themes.svn.wordpress.org/canvas/1.0.1/screenshot.png

Change History (5)

comment:1 chipbennett15 months ago

  • Owner set to chipbennett
  • Status changed from new to assigned

comment:2 follow-up: chipbennett15 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Carrying over from the theme-reviewers mail-list discussion:

This implementation entirely circumvents the WordPress Template Hierarchy, and adds its own, custom abstraction layer. Themes are required to support core functionality when integrating a given feature. I would suggest that this requirement extends to the template hierarchy itself.

You may want to look at a combination of template-part files and custom Theme hooks to accomplish the same thing that you're attempting to do here.

comment:3 in reply to: ↑ 2 amdhas15 months ago

Replying to chipbennett:

Carrying over from the theme-reviewers mail-list discussion:

This implementation entirely circumvents the WordPress Template Hierarchy, and adds its own, custom abstraction layer. Themes are required to support core functionality when integrating a given feature. I would suggest that this requirement extends to the template hierarchy itself.

You may want to look at a combination of template-part files and custom Theme hooks to accomplish the same thing that you're attempting to do here.

Hi chip,

  1. Can you give me a good reason why do_actions should not be used in the implementation of the theme?

http://codex.wordpress.org/Function_Reference/do_action

  1. Can you give me a good reason why this theme has been approved?

http://themes.trac.wordpress.org/ticket/9802

Canvas theme follow the rules As in the theme review, at this point:
http://codex.wordpress.org/Theme_Review#Theme_Template_Files

Theme is required to include, at a minimum:

index.php
comments.php (via comments_template())
screenshot.png

Recommended 4:3 W:H ratio, size 600x450px (2x the previous 300x225px, to account for Retina displays).
Maximum size: 600x450px
Should be a "reasonable facsimile" of the Theme after it is initially activated with default options

style.css

comment:4 follow-up: chipbennett15 months ago

Can you give me a good reason why do_actions should not be used in the implementation of the theme?

Oh, by all means, you are welcome to use custom action hooks in Themes.

Can you give me a good reason why this theme has been approved?

One, keep in mind: the Guidelines, and our interpretation of them, is not set in stone. We strive for constant improvement. Also, reviewers are human, and sometimes make mistakes (and performing Theme reviews incurs a rather steep learning curve). So for all these reasons, "but Theme X was approved" is never a valid argument.

Two, I would not have approved that Theme as-is, for the same reasons discussed here.

Theme is required to include, at a minimum...

The point isn't merely to include files with those names, but rather to ensure that the Theme minimally adheres to the Template Hierarchy.

comment:5 in reply to: ↑ 4 amdhas15 months ago

Replying to chipbennett:

Can you give me a good reason why do_actions should not be used in the implementation of the theme?

Oh, by all means, you are welcome to use custom action hooks in Themes.

Can you give me a good reason why this theme has been approved?

One, keep in mind: the Guidelines, and our interpretation of them, is not set in stone. We strive for constant improvement. Also, reviewers are human, and sometimes make mistakes (and performing Theme reviews incurs a rather steep learning curve). So for all these reasons, "but Theme X was approved" is never a valid argument.

Two, I would not have approved that Theme as-is, for the same reasons discussed here.

Theme is required to include, at a minimum...

The point isn't merely to include files with those names, but rather to ensure that the Theme minimally adheres to the Template Hierarchy.

Hi, chip
Do you see the of this theme?

You may misunderstand the purpose of my question, canvas themes templates comply with the hierarchy.

Would you please check and see some of the files as files in the directory inc.

http://themes.svn.wordpress.org/canvas/1.0.1/inc/

Last edited 15 months ago by amdhas (previous) (diff)
Note: See TracTickets for help on using tickets.