WordPress.org

Make WordPress Themes

Opened 15 months ago

Closed 14 months ago

Last modified 14 months ago

#10912 closed theme (not-approved)

THEME: Silver Blue - 1.0.1

Reported by: Alappin Owned by: life.object
Priority: Keywords: theme-silver-blue
Cc: alappin10@…

Description

Silver Blue - 1.0.1

The Silver Blue theme for WordPress is a fully responsive and elegant theme that looks great with a touch of silver and blue styling. Customizable menu, header image, and background.

Theme URL - http://www.alappin.com/wordpress-themes
Author URL - http://www.alappin.com/

SVN - http://themes.svn.wordpress.org/silver-blue/1.0.1
ZIP - http://wordpress.org/extend/themes/download/silver-blue.1.0.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/silver-blue/1.0&new_path=/silver-blue/1.0.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-silver-blue&order=id

https://themes.svn.wordpress.org/silver-blue/1.0.1/screenshot.png

Change History (5)

comment:1 life.object14 months ago

  • Owner set to life.object
  • Status changed from new to assigned

comment:2 follow-up: life.object14 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Review Summary:

  • This is a complete review.

Theme Plugin Test:

Plugin "Theme Check": Pass
Plugin "Debogger": Pass
Plugin "Log Deprecated Notices": None

Required Issues:

  • Scripts (i.e. libraries) should be enqueued via callback, rather than hard-coded in the document head.
  • Social networking links (facebook, twitter, skype) must be user-configurable, and disabled by default.

Recommended Issues:

  • You may set post thumbnail height 0 instead of 9999 for unlimited.

Theme Recommendation:

Thank you for your submission.

comment:3 in reply to: ↑ 2 alappin14 months ago

Replying to life.object:

Required Issues:

  • Scripts (i.e. libraries) should be enqueued via callback, rather than hard-coded in the document head.

What exactly was hard coded in the head that shouldn't be there??? Can you specify the actual code lines??? This theme is made using the 'Twenty Twelve' theme as the base. Whatever is in the head in this theme is also in the head of the 'Twenty Twelve' theme made by the wordpress team.

  • Social networking links (facebook, twitter, skype) must be user-configurable, and disabled by default.

I have removed the social networking feature so that's not an issue anymore.

Recommended Issues:

  • You may set post thumbnail height 0 instead of 9999 for unlimited.

Well this is just a recommendation. Again, the 9999 value used is based on the 'Twenty twelve' theme design.

I have made the necessary changes for the social networking links and will reupload the theme as version 1.0.2.

Last edited 14 months ago by alappin (previous) (diff)

comment:4 life.object14 months ago

@alappin

  • Scripts (i.e. libraries) should be enqueued via callback, rather than hard-coded in the document head.
<!--[if lt IE 9]>
<script src="<?php echo get_template_directory_uri(); ?>/js/html5.js" type="text/javascript"></script>
<![endif]-->
  • You may set post thumbnail height 0 instead of 9999 for unlimited.
    • set_post_thumbnail_size link might be helpful to you. Height is an optional parameter with the default value 0. It will improve your code quality.
  • New requirements/recommendations update periodically so developers require to change their own code.

Thanks

comment:5 alappin14 months ago

The "html5.js" has html5 support for browsers less than E9 as the code suggests. You do not want the script file to be included in the head for all the browsers so you can't enqueue the script. The server can't possibly know which browser it is before sending the file so this has to be done on the client browser side to determine whether to show or not show the script.

I thought of other solutions and checked other theme implementations such as 'twenty twelve' and found that to be the only sensible way it can be done really. If you have found a better way then please explain it in full. I have already uploaded version 1.0.2 with the other issues addressed http://themes.trac.wordpress.org/ticket/11285.

Note: See TracTickets for help on using tickets.