WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

#10950 closed theme (not-approved)

THEME: obandes - 1.48

Reported by: nobita Owned by: gpriday
Priority: Keywords: theme-obandes
Cc: a.tenman@…

Description

obandes - 1.48

lessphp (CSS preprocessor) support Where Theme option panel style editor. YUI(Yahoo User Inter face) Grid layout support. 2column fixed and fluid layout theme.Post format image support Zoom it API. This theme supply your happy blogging From beginners to a specialist

Theme URL - http://www.tenman.info/wp3/obandes/
Author URL - http://www.tenman.info/wp3/

SVN - http://themes.svn.wordpress.org/obandes/1.48
ZIP - http://wordpress.org/extend/themes/download/obandes.1.48.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/obandes/1.46&new_path=/obandes/1.48

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-obandes&order=id

https://themes.svn.wordpress.org/obandes/1.48/screenshot.png

Change History (2)

#1 @gpriday
5 years ago

  • Owner set to gpriday
  • Status changed from new to assigned

#2 @gpriday
5 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Issues mostly the same as my previous review.

Code Review

  • Required: Themes must not generate any errors or warnings - more info
    • After activation: Warning: array_key_exists() expects parameter 2 to be array, boolean given in /Users/gpriday/Sites/wptest/wp-content/themes/obandes/functions.php on line 1636
  • Required: Setup functions must be tied to actions hooked to the correct actions.
    • Function add_theme_support must not be called outside a theme function in functions.php. Should be called from within a function hooked to after_setup_theme action.
    • Function set_post_thumbnail_size must not be called outside a theme function in functions.php. Should be called from within a function hooked to after_setup_theme action.
  • Required: Themes are required to register all sidebars in function, hooked to widget_init action.
    • Function register_sidebar must be called in a function that's hooked to the action widgets_init in functions.php. Currently in function register_obandes_menus hooked to init.
  • Recommended: Themes should enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function. - more info
    • Function wp_enqueue_style must be called in a function that's hooked to the action wp_enqueue_scripts in functions.php. Currently in function obandes_init hooked to init.
    • Function wp_enqueue_script must be called in a function that's hooked to the action wp_enqueue_scripts in functions.php. Currently in function obandes_init hooked to init.
  • Required: Themes are required to use a unique slug as a prefix for anything in the public namespace. - more info
    • Found improperly prefixed functions or classes register_obandes_menus, plugin_is_active in functions.php
    • Found improperly prefixed functions or classes lessc, compileValue, lib_isnumber, lib_isstring, lib_iscolor, lib_iskeyword, lib_ispixel, lib_ispercentage, lib_isem, lib_rgbahex, lib_argb, lib_e, lib__sprintf, lib_floor, lib_ceil, lib_round, colorArgs, lib_darken, lib_lighten, lib_saturate, lib_desaturate, lib_spin, lib_fadeout, lib_fadein, lib_hue, lib_saturation, lib_lightness, lib_alpha, lib_fade, lib_percentage, lib_mix, assertColor, assertNumber, toHSL, toRGB_helper, toRGB, clamp, funcToColor, reduce, coerceColor, coerceString, flattenList, toBool, evaluate, stringConcatenate, fixColor, op_number_color, op_color_number, op_color_color, op_number_number, makeOutputBlock, pushEnv, popEnv, set, get, injectVariables, __construct, compile, compileFile, checkedCompile, cachedCompile, parse, makeParser, setFormatter, newFormatter, setPreserveComments, registerFunction, unregisterFunction, setVariables, unsetVariable, setImportDir, addImportDir, allParsedFiles, addParsedFile, throwError, ccompile, cexecute, lessc_parser, lessc_formatter_classic, lessc_formatter_compressed, lessc_formatter_lessjs in lib/lessc.inc.php
    • Found improperly prefixed functions or classes front_header_image in page-templates/front-page.php
  • Required: For security, themes should escape all user entered data. - more info
    • Found unescaped home_url in searchform.php

Conclusion

Note: See TracTickets for help on using tickets.