WordPress.org

Make WordPress Themes

Opened 15 months ago

Closed 14 months ago

Last modified 14 months ago

#10967 closed theme (not-approved)

THEME: FirmaSite - 1.0

Reported by: unsalkorkmaz Owned by: gpriday
Priority: Keywords: theme-firmasite
Cc: unsalkorkmaz@…

Description

FirmaSite - 1.0

FirmaSite is a responsive theme built on Twitter Bootstrap. Have 4 different layout: content-sidebar,sidebar-content, full content (long), full content(short). 13 different theme styles, Google Fonts, logo upload abilities. Unique 2 feature builtin: Promotion Bar and ShowCase. All options are using WordPress Theme Customizer feature so you can watch changes live! Designers: This theme have 0 custom css code and using template_part system so you can easily use it as parent theme!

Theme URL -
Author URL - http://firmasite.com/

SVN - http://themes.svn.wordpress.org/firmasite/1.0
ZIP - http://wordpress.org/extend/themes/download/firmasite.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-firmasite

https://themes.svn.wordpress.org/firmasite/1.0/screenshot.png

Change History (7)

comment:1 unsalkorkmaz15 months ago

I sadly removed csstidy from codes :(
Theme checker was giving error and wont accept csstdy which i got codes from jetpack plugin -.-

comment:2 unsalkorkmaz15 months ago

I released child theme that supports BuddyPress and bbPress that using FirmaSite theme as parent; FirmaSite Social: http://themes.trac.wordpress.org/ticket/11003

Last edited 15 months ago by unsalkorkmaz (previous) (diff)

comment:3 gpriday14 months ago

  • Owner set to gpriday
  • Status changed from new to assigned

comment:4 gpriday14 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Code Review

  • Recommended: Themes should enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function. - more info
    • Function wp_enqueue_script must be called in a function that's hooked to the action wp_enqueue_scripts in functions/fix.php. Currently in function firmasite_navigation_bottom hooked to close_content.
    • Function wp_enqueue_script must be called in a function that's hooked to the action wp_enqueue_scripts in functions/shortcodes.php. Currently in function firmasite_audio_func hooked to NONE.
    • Function wp_enqueue_script must be called in a function that's hooked to the action wp_enqueue_scripts in functions/shortcodes.php. Currently in function firmasite_video_func hooked to NONE.
    • Function wp_enqueue_script must be called in a function that's hooked to the action wp_enqueue_scripts in functions/shortcodes.php. Currently in function firmasite_replace_video_links hooked to NONE.
    • Function wp_enqueue_script must be called in a function that's hooked to the action wp_enqueue_scripts in functions/shortcodes.php. Currently in function firmasite_replace_audio_links hooked to NONE.
  • Required: Google fonts must be enqueued, not displayed directly in header.php
  • Required: Custom CSS must be outputted in a function hooked to wp_head or wp_print_styles, not directly in header.php
  • Required: Themes are required to register all sidebars in function, hooked to widget_init action.
    • Function register_sidebar must be called in a function that's hooked to the action widgets_init in functions/init.php. Currently in function firmasite_init hooked to init.
    • Function register_sidebar must be called in a function that's hooked to the action widgets_init in functions/init.php. Currently in function firmasite_init hooked to init.
  • Recommended: Themes should remove development/logging functions calls.
    • Found In assets/bootstrapformhelpers/docs/assets/js/google-code-prettify/prettify.js
      • Line 17: j;var u=i.ownerDocument,v=u.createElement('SPAN');v.className=d[a+1];var x=i.parentNode;x.replaceChild(v,i);v.appendChild(i);e<o&&(l[h+1]=i=u.createTextNode(t.substring(b,o)),x.insertBefore(i,v.nextSibling))}e=b;e>=o&&(h+=2);e>=c&&(a+=2)}}catch(w){'console'in window&&console.log(w&&w.stack?w.stack:w)}}var v=['break,continue,do,else,for,if,re
    • Found In assets/mediaelement/mediaelement-and-player.js
      • Line 1284: console.log('vimeoid');
      • Line 2263: console.log('timer fired');
      • Line 2338: console.log('error building ' + feature);
      • Line 2339: console.log(e);
      • Line 3572: console.log('supportsPointerEvents', supportsPointerEvents);
      • Line 4540: console.log('context hover out');
      • Line 4556: console.log('startContextMenuTimer');
      • Line 4570: console.log('killContextMenuTimer', timer);
    • Found In assets/mediaelement/mediaelement.js
      • Line 1284: console.log('vimeoid');
    • Found In assets/mediaelement/mediaelementplayer.js
      • Line 456: console.log('timer fired');
      • Line 531: console.log('error building ' + feature);
      • Line 532: console.log(e);
      • Line 1765: console.log('supportsPointerEvents', supportsPointerEvents);
      • Line 2733: console.log('context hover out');
      • Line 2749: console.log('startContextMenuTimer');
      • Line 2763: console.log('killContextMenuTimer', timer);
  • Required: Themes are required to use a unique slug as a prefix for anything in the public namespace. - more info
    • Found improperly prefixed functions or classes sanitize_customcss, safecss_class, safecss, Customize_CustomCss_Control in functions/custom-custom-css.php
    • Found improperly prefixed functions or classes Example_Customize_Textarea_Control, Customize_Explain_Control, Customize_ImageOptions_Control, Customize_GoogleFont_Control in functions/customizer.php
    • Found improperly prefixed functions or classes remove_more_link_scroll in functions/fix.php
    • Found improperly prefixed functions or classes Roots_Nav_Walker, roots_nav_menu_css_class, roots_nav_menu_args, is_element_empty in functions/nav.php
    • Found improperly prefixed functions or classes add_js_promotionbar_colum, add_js_promotionbar_post_column_content, js_promotionbar_posts_get_and_loop_through_post_types, js_promotionbar_posts_colum_width, js_promotionbar_posts_add_jquery_to_head, js_promotionbar_posts_link_add_ajax_call_to_wp in functions/promotionbar.php
    • Found improperly prefixed functions or classes Remove_Comments_Absolute in functions/remove-comments-absolute.php
    • Found improperly prefixed functions or classes extract_from_string in functions/shortcodes.php
    • Found improperly prefixed functions or classes add_js_showcase_colum, add_js_showcase_post_column_content, js_showcase_posts_get_and_loop_through_post_types, js_showcase_posts_colum_width, js_showcase_posts_add_jquery_to_head, js_showcase_posts_link_add_ajax_call_to_wp in functions/showcase.php
  • Required: Themes are required to use a unique slug for translation domain. Recommended to be theme slug. - more info
    • Found domains remove_comments_absolute in functions/remove-comments-absolute.php

Conclusion

comment:5 unsalkorkmaz14 months ago

I fixed all these little things except " Themes should enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function."
Its not required, only recommended and its not working for shortcodes..
http://scribu.net/wordpress/conditional-script-loading-revisited.html
http://core.trac.wordpress.org/ticket/9346

New upload with fix:
http://themes.trac.wordpress.org/ticket/11299

Please review this one so i can start to add new features which i have already lots of for 1.1 :) Thanks for your time to review.

comment:6 unsalkorkmaz14 months ago

FirmaSite 1.1 version:
http://themes.trac.wordpress.org/ticket/11437

bootstrap 2.3.1 upgrade, buddypress + bbpress support, tinymce custom buttons and more.

comment:7 unsalkorkmaz14 months ago

FirmaSite 1.1.1 version:
http://themes.trac.wordpress.org/ticket/11449

Removed some features. It seems plugin territory.

Note: See TracTickets for help on using tickets.