WordPress.org

Make WordPress Themes

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#11541 closed theme (closed-newer-version-uploaded)

THEME: Voyage - 1.2.0

Reported by: scui2 Owned by: chipbennett
Priority: Keywords: theme-voyage
Cc: scui2005@…

Description

Voyage - 1.2.0

Voyage Theme is a flexible and responsive premium theme that combines a modified version of 960.gs Grid System and Twitter Bootstrap framework. It allows users changing layout and style using flexible and simple Theme Options: 1-, 2- or 3-column blog layout; fixed, fluid or responsive; 12- or 16-column grid; grid width and many more. The Voyage Theme features 11 widget areas, 4 menu positions and 6 page templates including Featured Post, Landing Page, Featured Blog and Multi-Column Blog Summary/Portfolio with template options. The Theme includes 2 highly customizable widgets (Recent Post and Tabbed Navigation) and Integrated Jetpack Sharing. Voyage Theme supports aside, link, quote, image and gallery post format as of now. ColorBox and Font Awesome are included as a bonus.

Theme URL - http://www.voyagebc.com/voyagetheme
Author URL -

SVN - http://themes.svn.wordpress.org/voyage/1.2.0
ZIP - http://wordpress.org/extend/themes/download/voyage.1.2.0.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/voyage/1.1.9&new_path=/voyage/1.2.0

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-voyage&order=id

https://themes.svn.wordpress.org/voyage/1.2.0/screenshot.png

Change History (8)

comment:1 scui214 months ago

  • Removed front-page.php and created home.php for blog index as discussed in previous ticket.

comment:2 chipbennett14 months ago

  • Owner set to chipbennett
  • Status changed from new to assigned

comment:3 chipbennett14 months ago

Required

  • In home.php, you need to use the default query, not this:
    $blog = new WP_Query( $blog_args );
    
    • Basically, just remove the new WP_Query() call, and
    • Replace $blog->have_posts() with have_posts() and $blog->the_post() with the_post(), and
    • Remove wp_reset_postdata()

The power of using the core-defined template files is that you don't need to do anything to the query. WordPress will use the correct query parameters, out of the box. Less coding FTW. :)

I'll hold this open to allow time to fix. Let me know if you have any implementation questions.

comment:4 follow-up: scui214 months ago

Then it become index.php with 2 additional code. Can I remove home.php add the 2 line of codes in the index.php? I am ready to upload a new revision. Just need to make sure.

Maybe I missed something again. If the static front page is assigned, the core should use index.php not home.php for blog index. Anyway this is not my concerns.

Last edited 14 months ago by scui2 (previous) (diff)

comment:5 scui214 months ago

Anyway I uploaded the new version 1.2.0.1

http://themes.trac.wordpress.org/ticket/11543

I left index.php untouched because index.php is the default template. Although Voyage Theme has single.php and page.php, I leave it as is.

Thanks for your help. BTW I noticed the changes to Featured Themes. Hopefully Voyage will become one of those one day.

comment:6 in reply to: ↑ 4 chipbennett14 months ago

Replying to scui2:

Then it become index.php with 2 additional code. Can I remove home.php add the 2 line of codes in the index.php? I am ready to upload a new revision. Just need to make sure.

And that's fine, too! If index.php adequately renders the blog posts index, there's no need to add home.php (which falls back to index.php in the template hierarchy).

Maybe I missed something again. If the static front page is assigned, the core should use index.php not home.php for blog index. Anyway this is not my concerns.

For the blog posts index, the template hierarchy is in the following order:

  1. home.php
  2. index.php

Those are the only two files WordPress will ever use for the blog posts index, except and unless front-page.php exists, and the front page is set to display the blog posts index. In that one special case, front-page.php will be used.

comment:7 chipbennett14 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed

comment:8 greenshady14 months ago

Replying to scui2:

Then it become index.php with 2 additional code. Can I remove home.php add the 2 line of codes in the index.php? I am ready to upload a new revision. Just need to make sure.

Maybe I missed something again. If the static front page is assigned, the core should use index.php not home.php for blog index. Anyway this is not my concerns.

If a static front page is selected by the user, this is the hieararchy for the front page (i.e., is_front_page()) of the site:

  • front-page.php
  • page.php
  • index.php

If a static front page is selected by the user, this is the hierarchy for the posts page (i.e., is_home()) of the site:

  • home.php
  • index.php

If posts should show on the front, this is the hierarchy for the front page and posts page (now the same thing):

  • front-page.php
  • home.php
  • index.php

===

Also, you should change this code to use the appropriate conditional tag in home.php:

if ( 'posts' == get_option( 'show_on_front' ) )
	 get_template_part( 'partial/headlines'  );

To:

if ( is_front_page() )
	 get_template_part( 'partial/headlines'  );

Technically, the conditional for that is is_home() && is_front_page() but you already know is_home() is true since you're inside the home.php template.

Note: See TracTickets for help on using tickets.