WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11850 closed theme (not-approved)

THEME: agency - 1.1

Reported by: manish_gori Owned by: kobenland
Priority: Keywords: theme-agency
Cc: manish_gori@…

Description

agency - 1.1

A very neat and clean black and white business theme. The theme supports widgets. And features theme-options, threaded-comments and multi-level dropdown menu. A simple and neat typography.

Theme URL - http://antthemes.com/?page_id=2019
Author URL - http://antthemes.com/

SVN - http://themes.svn.wordpress.org/agency/1.1
ZIP - http://wordpress.org/extend/themes/download/agency.1.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/agency/1.0&new_path=/agency/1.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-agency&order=id

https://themes.svn.wordpress.org/agency/1.1/screenshot.png

Change History (3)

#1 @kobenland
5 years ago

  • Owner set to kobenland
  • Status changed from new to accepted

#2 @kobenland
5 years ago

  • Resolution set to not-approved
  • Status changed from accepted to closed

THEME REVIEW RESULTS

  • Previous version of Theme NOT-APPROVED

Code Quality

  • Themes are REQUIRED to escape all untrusted data before being output in the Theme template files
  • Theme may optionally incorporate translation/internationalization; however, if incorporated, translation/internationalization must support WordPress core functionality (all public facing text translatable, incl. credits)
  • Themes are REQUIRED to enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function, rather than hard-coding stylesheet/script links or tags in the template.
  • If incorporated into the Theme, custom template files are required to be called using get_template_part() or locate_template()
    • include( get_template_directory() . '/file.php' ) must not be used to call Theme template part files.
  • Please remove the following from functions.php, it is outdated code:
    $locale = get_locale();
    $locale_file = get_template_directory() . "/languages/$locale.php";
    if ( is_readable( $locale_file ) )
             require_once( $locale_file );
    
  • Please remove analytics code, this is plugin territory
  • Themes are required to use a unique slug as a prefix for anything in the public namespace, including all script/style handles

Theme Unit Test


Review Summary

  • This was not a complete review.
  • Theme has required issues (see above)
  • Ticket being resolved as NOT-APPROVED. Please address required issues in next Theme revision.

Thanks,
Konstantin

#3 @manish_gori
5 years ago

Please remove analytics code, this is plugin territory

=======================================================
Why can't option be given for users in theme options panel to add analytics code? the code is just doing that in functions.php
=======================================================

Themes are required to use a unique slug as a prefix for anything in the public namespace, including all script/style handles

=======================================================
This been taken are of, where you find this problem, please advise?
=======================================================

Themes are REQUIRED to enqueue all stylesheets and scripts, using wp_enqueue_style()/wp_enqueue_script(), and hooked into an appropriate hook via callback function, rather than hard-coding stylesheet/script links or tags in the template.

=======================================================
This been taken are of, where you find this problem, please advise?
=======================================================

Note: See TracTickets for help on using tickets.