WordPress.org

Make WordPress Themes

Opened 13 months ago

Closed 12 months ago

Last modified 10 months ago

#11940 closed theme (not-approved)

THEME: Fruit Shake - 1.0

Reported by: automattic Owned by: matt_s
Priority: major Keywords: theme-fruit-shake
Cc: themes@…

Description

Fruit Shake - 1.0

Fruit Shake features multiple fruit flavors (color schemes actually, including a secret unlockable one), an optional, one-column, tumblelog layout (just remove the widgets from your sidebar to see it), and all your favorite theme features like custom headers, backgrounds, and menus. It's a perfectly fruitylicious theme for your blog.

Theme URL - http://theme.wordpress.com/themes/fruit-shake/
Author URL - http://automattic.com/

SVN - http://themes.svn.wordpress.org/fruit-shake/1.0
ZIP - http://wordpress.org/extend/themes/download/fruit-shake.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-fruit-shake

https://themes.svn.wordpress.org/fruit-shake/1.0/screenshot.png

Attachments (2)

Post format image.png (259.3 KB) - added by matt_s 12 months ago.
Post format link.png (19.3 KB) - added by matt_s 12 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 matt_s12 months ago

  • Owner set to matt_s
  • Status changed from new to assigned

matt_s12 months ago

matt_s12 months ago

comment:2 follow-up: matt_s12 months ago

Theme Check

  • Recommended: get_current_theme found in the file theme-options.php (line 67). Deprecated since version 3.4. Use wp_get_theme() instead.
  • Recommended: add_custom_image_header found in the file custom-header.php (line 43). Deprecated since version 3.4. Use add_theme_support( 'custom-header', $args ) instead.

Theme Activation Tests

Custom Theme Settings

  • Required: Header: Clicking "Remove Header Image" reverts the user's custom header image to the theme default one, but does not actually "removes" the header image.

W3C

  • Note: HTML5: The <hgroup> element is obsolete (used in header.php on line 23)

Theme Unit Test

  • Required: Index view: "Post Format Test: Image (Attached)" and "Post Format Test: Image (Linked)" are not displayed properly. See Attachment
  • Required: "Clearing Floats" (Page): The element after the floated image (edit link for logged in users) is not clearing.
  • Required: "Images test: Clearing Floats" (Post): Elements after the floated images (page links) are not clearing.
  • Note: Post Format Test: Link: the edit link seems to float over the bottom border of the post. See Attachment
  • Note: Comment Test: Table in comment is not styled (but still displays correctly).

Review Summary

  • This is a complete review
  • Theme has required issue(s) (see above)
  • Ticket being resolved as NOT-APPROVED
  • Please address all issues in the next theme revision
  • I will leave this ticket open for 2 days. Feel free to ping me if a revision is submitted that addresses these issues, and the review will continue on the new ticket.
Last edited 12 months ago by matt_s (previous) (diff)

comment:3 matt_s12 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

With no update from theme author in 7 days, I'm now closing this ticket.

Feel free to reply here if a revision is submitted later.

comment:4 in reply to: ↑ 2 kobenland10 months ago

  • Priority set to major

Hi Matt,

Thanks for reviewing Fruit Shake!

We addressed everything except for the following:

Replying to matt_s:

Required: Index view: "Post Format Test: Image (Attached)" and "Post Format Test: Image (Linked)" are not displayed properly. See Attachment

The image in the Unit Test is smaller than the content width and not aligned. If it would be center aligned or as wide as the content area it would subjectively look better, but this is a user setting.

The new ticket can be found here: #13282.

Thanks,
Konstantin

Note: See TracTickets for help on using tickets.