Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

#12022 closed theme (closed-newer-version-uploaded)

THEME: oriental - 1.3.7

Reported by: dodo Owned by: chipbennett
Priority: Keywords: theme-oriental
Cc: dodozhang21@…


oriental - 1.3.7

Created by <a href="http://pure-essence.net/">pure-essence.net</a>. Oriental, plum, bamboo, pine, flower, foliage, orange, red theme. Now compatible with wordpress 3.5.1 and with responsive design. Supports Jetpack infinite scroll.

Theme URL - http://pure-essence.net/2008/09/19/wordpress-theme-oriental/
Author URL - http://regretless.com

SVN - http://themes.svn.wordpress.org/oriental/1.3.7
ZIP - http://wordpress.org/extend/themes/download/oriental.1.3.7.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/oriental/1.3.6&new_path=/oriental/1.3.7

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-oriental&order=id


Change History (5)

#1 @chipbennett
5 years ago

  • Owner set to chipbennett
  • Status changed from new to assigned

#2 @chipbennett
5 years ago

Previous-Ticket Required Issues

  • Textdomain issue: fixed
  • Image test: N/A
  • Nav Menu limitation: fixed (readme note)
  • Tinynav: N/A
  • wp_title() parameters: N/A
  • Inline CSS: N/A
  • License/License URI: fixed
  • Copyright notice: not fixed This applies to original works and to derivative works. Copyright notice must be included (usually either in style.css or readme.txt). If the work is original, e.g.:
    Oriental WordPress Theme, copyright 2013 Ying Zhang
    Oriental is distributed under the terms of the GNU GPLv2
    If the work is derivative:
    Oriental WordPress Theme, copyright 2013 Ying Zhang
    Oriental is distributed under the terms of the GNU GPLv2
    Oriental is a derivative work of Twenty Eleven, Copyright 2011 WordPress.org
    Twenty Eleven is distributed under the terms of the GNU GPL


  • This is Plugin territory:
    // allow html in category and taxonomy descriptions 
    remove_filter( 'pre_term_description', 'wp_filter_kses' ); 
    remove_filter( 'pre_link_description', 'wp_filter_kses' ); 
    remove_filter( 'pre_link_notes', 'wp_filter_kses' ); 
    remove_filter( 'term_description', 'wp_kses_data' ); 
    Two issues: one, term descriptions remain when switching Themes; and two, the filters aren't replaced with a less-restrictive filter (such as wp_filter_post_kses) that allows HTML, resulting in unfiltered data.
  • Is this a JetPack function: jetpack_is_mobile()? If so, it needs a function_exists() conditional wrapper

Review Summary

  • Previous version of Theme approved
  • Theme has previous-ticket required issues
  • Diff-review and file-review only
  • Changes as per change log
  • Theme has required issues (current and outstanding from previous ticket)
  • I will hold this ticket open for a short time, to allow for developer response

#3 @dodo
5 years ago

Chip, thank you for the feedback. I will address the copyright issue and I will probably remove the remove_filter part. That was required by someone who donated for the theme. To keep it compliant, I will recommend the user to use a plugin instead. I will be able to upload a new version soon.

#5 @chipbennett
5 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.